Direct relations list fix

[Jacob-Eliat-Eliat]

Changes:

• Cosmetic: creating a method "getListPropAsSeq" to handle parsing of a row into a list The method is generic and can parse into any type, but I decided to use it to replace the code that was there in place, so I parse into whatever it was first parsed into before. This was done because this piece of code was repeated for each possible list property.

• Cosmetic: dealing with number parsing in a generic way. There were hundreds of lines of code dedicated to parsing numbers and the way they all worked was to parse like this: => any => string => bigint => specific type. I decided to constrain my change to just code deduplication for now, so I created a second order function that takes the final transformation bigint => specific type and does everything.

• Cosmetic: I deleted the if p.isList in all cases of the list handling, and the opposite in the non-list handling because we already test this before entering the method.

• Cosmetic/Functional: I moved the parsing of DirectRelations from happening before the flow separation into lists to happening inside it. So now non-list direct relations are handled in the "toInstancePropertyValueOfNonList" whereas before they were a separate case

• Functional: I added handling of DirectRelations in toInstancePropertyValueOfList For that I reworked extractDirectRelationReferenceFromStruct and I added the method tryAsDirectNodeRelationList

In the end that's not a lot of functional changes, but it was a bit messy to figure out how it works and how the tests should actually work!

[codecov]

Codecov Report

Attention: Patch coverage is 67.02128% with 31 lines in your changes missing coverage. Please review.

Project coverage is 81.12%. Comparing base (3928266) to head (6a46af4).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #946      +/-   ##
==========================================
+ Coverage   80.85%   81.12%   +0.26%     
==========================================
  Files          46       46              
  Lines        3087     3046      -41     
  Branches      120      117       -3     
==========================================
- Hits         2496     2471      -25     
+ Misses        591      575      -16     

Files	Coverage Δ
...nite/spark/v1/FlexibleDataModelRelationUtils.scala	72.05% <67.02%> (+1.11%)	⬆️

[dmivankov]

Haven't read the bulk of dms change part, but so far changes are dms-only, old tests pass and one new is added so looks good so far 🙂 but will try to read through the main part too

[Jacob-Eliat-Eliat]

Haven't read the bulk of dms change part, but so far changes are dms-only, old tests pass and one new is added so looks good so far 🙂 but will try to read through the main part too

most of it is just cleanup/code deduplication, the actual changes needed for this were pretty small, but I had some trouble understanding the existing code correctly!

[dmivankov]

the actual changes needed for this were pretty small

could you point to a summary or place in diff? Looking at commits in the PR there is some separation of changes but a bit too many to easily split into cosmetic&refactor vs the fix

[Jacob-Eliat-Eliat]

the actual changes needed for this were pretty small

could you point to a summary or place in diff? Looking at commits in the PR there is some separation of changes but a bit too many to easily split into cosmetic&refactor vs the fix

Will do in the PR header. Yeah sorry about the number of commits, lots of them are just scalafmt and stuff like that as well ^^

[dmivankov]

some small notes for the non-fix part