chore: replace eslint/prettier with biome #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BugGambit
commented
Aug 19, 2024
Comment on lines
+230
to
+259
| const normalizedParams: Record<string, string> = Object.entries( | ||
| params | ||
| ).reduce( | ||
| (acc, [key, value]) => { | ||
| switch (typeof value) { | ||
| case 'undefined': { | ||
| return acc; | ||
| } | ||
| case 'string': | ||
| case 'number': | ||
| case 'boolean': { | ||
| acc[key] = `${value}`; | ||
| return acc; | ||
| } | ||
| case 'object': { | ||
| if (Array.isArray(value)) { | ||
| acc[key] = `[${value.join(',')}]`; | ||
| } | ||
| return acc; | ||
| } | ||
| default: { | ||
| throw new Error( | ||
| `Unsupported value query parameter type: ${typeof value}, ${key}: ${value}` | ||
| ); | ||
| } | ||
| } | ||
| }, | ||
| {} as Record<string, string> | ||
| ); | ||
| const search = new URLSearchParams(normalizedParams).toString(); |
There was a problem hiding this comment.
Biome was strictier in the type and we had to open up for params to be type of object. URLSearchParams can't take in a generic object, so we need to handle each type.
danlevings
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of splitting up this PR: #1128
Biome is an efficient linter and formatted.
This PR replaces eslint/prettier with Biome and formats our files accordingly.
Jira: https://cognitedata.atlassian.net/browse/AUTH-3069