Neat 186 duplicated spaces bug (#414)

[0.75.5] - 24-05-24 Fixed Potential of having duplicated spaces are now fixed
cognitedata · Apr 24, 2024 · a4baef0 · a4baef0
1 parent 324e4c9
commit a4baef0
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 5 deletions.
diff --git a/Makefile b/Makefile
@@ -1,6 +1,6 @@
 .PHONY: run-explorer run-tests run-linters build-ui build-python build-docker run-docker compose-up
 
-version="0.75.4"
+version="0.75.5"
 run-explorer:
 	@echo "Running explorer API server..."
 	# open "http://localhost:8000/static/index.html" || true

diff --git a/cognite/neat/_version.py b/cognite/neat/_version.py
@@ -1 +1 @@
-__version__ = "0.75.4"
+__version__ = "0.75.5"
diff --git a/cognite/neat/rules/models/rules/_dms_architect_rules.py b/cognite/neat/rules/models/rules/_dms_architect_rules.py
@@ -762,7 +762,8 @@ def _create_spaces(
             data_model.space = used_spaces.pop()
             spaces = dm.SpaceApplyList([dm.SpaceApply(space=data_model.space)])
         else:
-            spaces = dm.SpaceApplyList([metadata.as_space()] + [dm.SpaceApply(space=space) for space in used_spaces])
+            used_spaces.add(metadata.space)
+            spaces = dm.SpaceApplyList([dm.SpaceApply(space=space) for space in used_spaces])
         if self.instance_space and self.instance_space not in {space.space for space in spaces}:
             spaces.append(dm.SpaceApply(space=self.instance_space, name=self.instance_space))
         return spaces

diff --git a/cognite/neat/rules/models/rules/_types/_base.py b/cognite/neat/rules/models/rules/_types/_base.py
@@ -30,7 +30,7 @@
 else:
     from typing_extensions import Self
 
-
+# mypy: ignore-errors
 VERSION_ID_REGEX = rf"\(version=(?P<version>{VERSION_REGEX})\)"
 
 

diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -15,6 +15,10 @@ Changes are grouped as follows:
 - `Fixed` for any bug fixes.
 - `Security` in case of vulnerabilities.
 
+## [0.75.5] - 24-05-24
+### Fixed
+- Potential of having duplicated spaces are now fixed
+
 ## [0.75.4] - 24-05-24
 ### Fixed
 - Rendering of correct metadata in UI for information architect

diff --git a/docs/artifacts/rules/~$information-architect-david.xlsx b/docs/artifacts/rules/~$information-architect-david.xlsx
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "cognite-neat"
-version = "0.75.4"
+version = "0.75.5"
 readme = "README.md"
 description = "Knowledge graph transformation"
 authors = [