Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocate textures holding color and visibility to be big enough to hold the correct number of tree indices. #313

Merged
merged 17 commits into from Mar 26, 2020

Conversation

larsmoa
Copy link
Contributor

@larsmoa larsmoa commented Mar 21, 2020

No description provided.

@larsmoa larsmoa added auto-update Makes bulldozer automatically update this PR when there are changes to the target branch auto-merge labels Mar 21, 2020
@larsmoa larsmoa requested review from dragly and j-bjorne March 21, 2020 17:11
@larsmoa larsmoa self-assigned this Mar 21, 2020
@codecov
Copy link

codecov bot commented Mar 21, 2020

Codecov Report

Merging #313 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
+ Coverage   65.19%   65.25%   +0.05%     
==========================================
  Files          74       75       +1     
  Lines        2066     2072       +6     
  Branches      175      175              
==========================================
+ Hits         1347     1352       +5     
- Misses        717      718       +1     
  Partials        2        2              
Impacted Files Coverage Δ
viewer/src/utils/determinePowerOfTwoDimensions.ts 100.00% <100.00%> (ø)
viewer/src/views/threejs/cad/CadNode.ts 72.00% <100.00%> (+0.28%) ⬆️
viewer/src/views/threejs/cad/MaterialManager.ts 83.33% <100.00%> (ø)
viewer/src/views/threejs/cad/materials.ts 100.00% <100.00%> (ø)
viewer/src/migration/Cognite3DViewer.ts 63.94% <0.00%> (-0.43%) ⬇️

@dragly dragly merged commit 4ff309b into master Mar 26, 2020
@dragly dragly deleted the larsmoa/allocate-correct-texture-size branch March 26, 2020 13:40
dragly added a commit that referenced this pull request Mar 26, 2020
…gh to hold the correct number of tree indices. (#313)"

This reverts commit 4ff309b.
dragly added a commit that referenced this pull request Mar 26, 2020
…gh to hold the correct number of tree indices. (#313)"

This reverts commit 4ff309b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants