Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn user when scb is provided but there is no file #1

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

sahankj2000
Copy link
Collaborator

Description

When a user provides the secureconnectbundle to a cqld4 adapter, it silently fails in the driver without telling the user it could not find the file

Issues: 1668 and 982

Original Error:

java.lang.RuntimeException: javax.script.ScriptException: io.nosqlbench.nb.api.errors.OpConfigError: Error while configuring op from workload template: 
[from:yaml:/path/to/workload.yaml]  cause: AllNodesFailedException:Could not reach any contact point, 
make sure you've provided valid addresses (showing first 1 nodes, use getAllErrors() for more): 
Node(endPoint=localhost/127.0.0.1:9042, hostId=null, hashCode=31dd7ba2): 
...

After adding warning:

4047 ERROR [main] Cqld4Space   Unable to load path /path/to/non-existing/bundle.zip
4059 ERROR [main] NBInvokableCommand error in command (stack trace follows): NBScriptedCommand 
{container="default",instance="default",jobname="nosqlbench",node="192.168.0.179",session="nOjgBos",step="phase_1"}: 
java.lang.RuntimeException: javax.script.ScriptException: io.nosqlbench.nb.api.errors.OpConfigError: Error while configuring 
op from workload template: [from:yaml:/path/to/workload.yaml]  cause: RuntimeException:Unable to load path 
/path/to/non-existing/bundle.zip Unable to load path /path/to/non-existing/bundle.zip
...

logger.error(error);
throw new RuntimeException(error);
}
}
Copy link
Collaborator

@sumit-ct sumit-ct Jan 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add else case when scb file itself is not given? Or is it handled someplace else, in that case do we need to remove first if condition?

@Srinathc Srinathc merged commit 8cfab7a into main Jan 12, 2024
@Srinathc Srinathc deleted the warn-scb-not-found branch January 12, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants