Add "More Menu" to Toolbar #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cohenerickson
requested changes
Apr 18, 2023
There was a problem hiding this comment.
Looks good from what I can see at the moment, I do see that some colors are hard coded into the styles but I think that is left over from when I added theme support, I don't expect you to fix this but if you would like to feel free to. I used this resource for the theme information.
src/components/Utility.tsx
Outdated
|
|
||
| let MenuItem = ( |
There was a problem hiding this comment.
Could you move this (and any other related things) to a new Menu component instead of having it right in the Utility component? It would make the code easier to read for new people if this is separated a bit more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The context menu was also restyled to be more consistent.
Before:
After:
Many options are grayed out because they have not been implemented