Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend: Refactor Retriever/Function tools into single Tool concept #154

Merged
merged 6 commits into from
May 29, 2024
Merged

backend: Refactor Retriever/Function tools into single Tool concept #154

merged 6 commits into from
May 29, 2024

Conversation

tianjing-li
Copy link
Collaborator

  • Removes the notion of Retriever or Function tools, they are now all considered tools
  • Now all tools should inherit from BaseTool
  • Updates all existing config and imports
  • Updates unit tests

BeatrixCohere
BeatrixCohere reviewed May 28, 2024
View reviewed changes
src/backend/tools/lang_chain.py Outdated Show resolved Hide resolved
src/backend/tools/lang_chain.py Outdated Show resolved Hide resolved
src/backend/tools/tavily.py Outdated Show resolved Hide resolved
src/backend/config/tools.py Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024 •
edited

Codecov Report

Attention: Patch coverage is 97.14286% with 1 lines in your changes are missing coverage. Please review.

Please upload report for BASE (main@40bd862). Learn more about missing BASE report.

Files Patch % Lines
src/backend/tools/tavily.py 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage        ?   88.62%           
=======================================
  Files           ?      113           
  Lines           ?     3622           
  Branches        ?        0           
=======================================
  Hits            ?     3210           
  Misses          ?      412           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lusmoura
lusmoura approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@lusmoura lusmoura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 just one nit

docs/custom_tool_guides/tool_guide.md Outdated Show resolved Hide resolved
@tianjing-li tianjing-li requested a review from lusmoura May 29, 2024 15:45
@tianjing-li tianjing-li merged commit 84c320e into main May 29, 2024
2 checks passed
@tianjing-li tianjing-li deleted the tool-docs branch May 29, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lusmoura lusmoura lusmoura approved these changes

@EugeneLightsOn EugeneLightsOn Awaiting requested review from EugeneLightsOn EugeneLightsOn is a code owner

@malexw malexw Awaiting requested review from malexw malexw is a code owner

@scottmx81 scottmx81 Awaiting requested review from scottmx81 scottmx81 is a code owner

@scott-cohere scott-cohere Awaiting requested review from scott-cohere

@BeatrixCohere BeatrixCohere Awaiting requested review from BeatrixCohere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tianjing-li @codecov-commenter @lusmoura @BeatrixCohere