coral-web: update assistant #248

misspia-cohere · 2024-06-19T21:46:51Z

Thank you for contributing to the Cohere Toolkit!

Screen.Recording.2024-06-19.at.17.43.52.mov

PR title: "area: description"
- Where "area" is whichever of interface, frontend, model, tools, backend, etc. is being modified. Use "docs: ..." for purely docs changes, "infra: ..." for CI changes.
- Example: "deployment: add Azure model option"
PR message: Delete this entire checklist and replace with
- Description: a description of the change
- Issue: the issue # it fixes, if applicable
- Dependencies: any dependencies required for this change
Add tests and docs: Please include testing and documentation for your changes
Lint and test: Run make lint and make run-tests

AI Description

This PR introduces a new feature that allows users to update their knowledge agents and adds a left panel to the agent interface, displaying the base agent, a list of agents, and an "Add Agent" button.

New files:
- src/interfaces/coral_web/src/components/Agents/CustomAgentButton.tsx
- src/interfaces/coral_web/src/components/Agents/LeftPanel.tsx
- src/interfaces/coral_web/src/components/Conversation/UpdateAgentDrawer.tsx
Modified files:
- src/interfaces/coral_web/pnpm-lock.yaml
- src/interfaces/coral_web/src/cohere-client/client.ts
- src/interfaces/coral_web/src/components/Agents/AgentForm.tsx
- src/interfaces/coral_web/src/components/Conversation/Header.tsx
- src/interfaces/coral_web/src/components/Conversation/MessagingContainer.tsx
- src/interfaces/coral_web/src/components/Conversation/index.tsx
- src/interfaces/coral_web/src/components/Shared/Input/Input.tsx
- src/interfaces/coral_web/src/hooks/agents.ts
- src/interfaces/coral_web/src/hooks/session.ts
- src/interfaces/coral_web/src/pages/agents/index.tsx
- src/interfaces/coral_web/src/stores/slices/settingsSlice.ts
- src/interfaces/coral_web/tailwind.config.js

Update Agent Functionality

The UpdateAgentDrawer component in UpdateAgentDrawer.tsx allows users to update their knowledge agents. It uses the useUpdateAgent hook from agents.ts to update the agent's information. The UpdateAgent function in client.ts makes the API request to update the agent.

Agent Left Panel

The LeftPanel component in LeftPanel.tsx renders the left panel in the agent interface. It displays the base agent, a list of agents using the CustomAgentButton component, and an "Add Agent" button. The CustomAgentButton component renders a button to navigate to a user-created knowledge agent page.

Other Changes

Added a new useSession hook in session.ts to get the user ID.
Added a new useAgent hook in agents.ts to get agent information.
Updated the Header component in Header.tsx to include a new "Update assistant" menu item and an "About assistant" menu item.
Updated the MessagingContainer component in MessagingContainer.tsx to include a new isEditAgentDrawerOpen prop.
Updated the Conversation component in index.tsx to include a new agentId prop and render the UpdateAgentDrawer component.
Updated the Input component in Input.tsx to include a new disabled prop.
Updated the useIsAgentNameUnique hook in agents.ts to include an omittedAgentId parameter.
Updated the AgentsPage component in index.tsx to include a new agentId prop.
Added a new isEditAgentDrawerOpen field to the initial state in settingsSlice.ts.
Added new agent-drawer sizes in tailwind.config.js.

src/interfaces/coral_web/src/hooks/session.ts

src/interfaces/coral_web/src/components/Agents/AgentForm.tsx

src/interfaces/coral_web/pnpm-lock.yaml

src/interfaces/coral_web/src/components/Agents/AgentForm.tsx

src/interfaces/coral_web/src/components/Agents/UpdateAgentDrawer.tsx

src/interfaces/coral_web/src/components/Conversation/Header.tsx

src/interfaces/coral_web/src/components/Conversation/index.tsx

src/interfaces/coral_web/src/hooks/agents.ts

src/interfaces/coral_web/src/components/Agents/UpdateAgentDrawer.tsx

src/interfaces/coral_web/tailwind.config.js

src/interfaces/coral_web/src/components/Agents/UpdateAgentDrawer.tsx

src/interfaces/coral_web/src/components/Conversation/Header.tsx

src/interfaces/coral_web/src/components/Agents/AgentForm.tsx

knajjars · 2024-06-20T10:13:19Z

I created a PR that addresses all the code feedback: #249

address code feedback improvements

* create new agent form * render agents list * link back to base agent page * perform post submission actions * move input labels outside of input borders * move submit button * gen client * factor out agent base form * check if agent name is unique * and deployment + env variables to agent form * add deployments * clean up * remove deployments dropdown * init agent page * create agent drawer * use agent form * add update agent request * add get agent request * fix rebase errors * remove model from agent form * add agent drawer to conversation * remove unused componenets * use new agent name for update success message * fix(toolkit): Address code feedback + improvements (#249) address code feedback improvements --------- Co-authored-by: Khalil Najjar <knajjars@gmail.com>

* Initial commit for Compass Tool * coral-web: update first turn suggestions (#225) * Addressed comments on the previous commit * Added custom_context to parse and filters to search * Formatting changes * feat(assistant): Update conversation header (#229) * feat(assistant): Update conversation header * feat(assistant): Update conversation header * update tooltip * fix IconButton import * Setup: fix dependencies (#243) * feat(toolkit): show conversation list on with agents list (#231) * Setup: remove redundant dependency (#244) * Improve Auth guide (#235) improve auth guide * coral-web: create agent + agent base form (#212) * create new agent form * render agents list * link back to base agent page * perform post submission actions * move input labels outside of input borders * move submit button * gen client * factor out agent base form * use default content type * list custom agents * check if agent name is unique * and deployment + env variables to agent form * add deployments * clean up * add submit modal * push to new agent page on create success * only show available deployments * remove deployments dropdown * feat: List Assistants returned from API (#242) * feat: list agents from BE * Update src/interfaces/coral_web/src/components/Conversation/MessagingContainer.tsx Co-authored-by: misspia-cohere <140425731+misspia-cohere@users.noreply.github.com> --------- Co-authored-by: misspia-cohere <140425731+misspia-cohere@users.noreply.github.com> * nits --------- Co-authored-by: Khalil Najjar <knajjars@gmail.com> * Propagate should_store logic to the File upload logic (#247) should_store logic to the attach_files_to_messages * [backend] passing in agent when calling streaming chat (#237) * initial chat changes * need to test * done * Remove old test * default model for agents right now * Organizations DB models, CRUD and tests (#238) * Organizations initial commit * Organizations initial commit * Organizations initial commit - sync main * Organizations initial commit - sync main - blacked * Organizations initial commit - sync main - lint * Organizations initial commit - sync main - tests * Organizations initial commit - sync main - tests * Organizations initial commit - review fixes * Organizations initial commit - review fixes * Split up display name and name for Tools (#241) * CHange * change * coral-web: update assistant (#248) * create new agent form * render agents list * link back to base agent page * perform post submission actions * move input labels outside of input borders * move submit button * gen client * factor out agent base form * check if agent name is unique * and deployment + env variables to agent form * add deployments * clean up * remove deployments dropdown * init agent page * create agent drawer * use agent form * add update agent request * add get agent request * fix rebase errors * remove model from agent form * add agent drawer to conversation * remove unused componenets * use new agent name for update success message * fix(toolkit): Address code feedback + improvements (#249) address code feedback improvements --------- Co-authored-by: Khalil Najjar <knajjars@gmail.com> * feat(toolkit): add/remove recently used agents (#250) * feat(toolkit): add/remove recently used agents * merge main * Add a walkthrough guide of the toolkit (#251) * GUide * Chang * Change * Change * Update docs/walkthrough/walkthrough.md Co-authored-by: Luísa Moura <luisa@cohere.com> * Update walkthrough.md --------- Co-authored-by: Luísa Moura <luisa@cohere.com> * coral-web: fix agent info panel opening by default (#253) cast isEditAgentPanelOpen to boolean * [backend] enforce agent update with user-id (#246) * updates * remove client changes * remove logs * use better header user id check * fix validators * typo * Metrics: add middleware (#185) * Metrics: add middleware * add chat calls * merge * lint * make it async * add user id * add more fields * add retry and duration * add meta * comments * fix tests * improve error handling * rename fields * match spec * comments * clean code * only create loop when theres endpoint * add assistant id to chat * feat(toolkit): show assistant welcome message (#255) * feat(toolkit): show assistant welcome message * feat(toolkit): show assistant welcome message * frontend: Login, logout, and account creation (#179) * add login page components * Add Register page and hooks for auth * Add the register page and connect all the frontend elements * Redirect to /login if the token expires and clean up some console errors * Add error messages for failed logins * frontend: Add Single Sign-on to Toolkit (#227) * Add Google SSO login plus OpenID components * Dynamically set SSO login buttons and show or hide username and password based on auth_strategies --------- Co-authored-by: Tianjing Li <tianjinglimail@gmail.com> * fix startup event * Fix build errors and update the API client * Fix tests by adding missing env vars Add test OIDC_WELL_KNOWN_ENDPOINT var to fixtures * Add a walkthrough guide of the toolkit (#251) * GUide * Chang * Change * Change * Update docs/walkthrough/walkthrough.md Co-authored-by: Luísa Moura <luisa@cohere.com> * Update walkthrough.md --------- Co-authored-by: Luísa Moura <luisa@cohere.com> * coral-web: fix agent info panel opening by default (#253) cast isEditAgentPanelOpen to boolean * [backend] enforce agent update with user-id (#246) * updates * remove client changes * remove logs * use better header user id check * fix validators * typo * Metrics: add middleware (#185) * Metrics: add middleware * add chat calls * merge * lint * make it async * add user id * add more fields * add retry and duration * add meta * comments * fix tests * improve error handling * rename fields * match spec * comments * clean code * only create loop when theres endpoint * add assistant id to chat * feat(toolkit): show assistant welcome message (#255) * feat(toolkit): show assistant welcome message * feat(toolkit): show assistant welcome message --------- Co-authored-by: misspia-cohere <pia@cohere.com> Co-authored-by: Tianjing Li <tianjinglimail@gmail.com> Co-authored-by: Beatrix De Wilde <128378696+BeatrixCohere@users.noreply.github.com> Co-authored-by: Luísa Moura <luisa@cohere.com> Co-authored-by: misspia-cohere <140425731+misspia-cohere@users.noreply.github.com> Co-authored-by: Scott <146760070+scott-cohere@users.noreply.github.com> Co-authored-by: Khalil Najjar <knajjars@gmail.com> * fix(toolkit): UX/UI improvements (#257) * Add error troubleshooting (#262) * Update chat.py --------- Co-authored-by: Jessica Wu <jessica@cohere.ai> Co-authored-by: Khalil Najjar <knajjars@gmail.com> Co-authored-by: Luísa Moura <luisa@cohere.com> Co-authored-by: Tomeu <tomeu@cohere.com> Co-authored-by: Tianjing Li <tianjinglimail@gmail.com> Co-authored-by: misspia-cohere <140425731+misspia-cohere@users.noreply.github.com> Co-authored-by: Eugene P <144219719+EugeneLightsOn@users.noreply.github.com> Co-authored-by: Scott <146760070+scott-cohere@users.noreply.github.com> Co-authored-by: Beatrix De Wilde <128378696+BeatrixCohere@users.noreply.github.com> Co-authored-by: Alex W <alex@blinkenlights.ca> Co-authored-by: misspia-cohere <pia@cohere.com>

misspia-cohere added 21 commits June 19, 2024 12:50

create new agent form

f0f0d87

render agents list

e5a7c9b

link back to base agent page

8679d3c

perform post submission actions

e97e68f

move input labels outside of input borders

051bcb5

move submit button

10b6a8a

gen client

8d78be2

factor out agent base form

a2934c2

check if agent name is unique

f0877d1

and deployment + env variables to agent form

061bd86

add deployments

41bb56e

clean up

15b3cbe

remove deployments dropdown

4a275bf

init agent page

af5640a

create agent drawer

d896f87

use agent form

fc28937

add update agent request

6893ad3

add get agent request

70f9dd9

fix rebase errors

7152ef3

remove model from agent form

f9c82b3

add agent drawer to conversation

e619245

misspia-cohere requested review from EugeneLightsOn, malexw, scottmx81, tianjing-li and a team as code owners June 19, 2024 21:46

misspia-cohere requested a deployment to development June 19, 2024 21:46 — with GitHub Actions Waiting

misspia-cohere commented Jun 19, 2024

View reviewed changes

src/interfaces/coral_web/src/hooks/session.ts Show resolved Hide resolved

remove unused componenets

b9495e4

misspia-cohere requested a deployment to development June 19, 2024 21:50 — with GitHub Actions Waiting

misspia-cohere requested a deployment to development June 19, 2024 21:53 — with GitHub Actions Waiting

use new agent name for update success message

e5ac49f

misspia-cohere force-pushed the pia/tlk-682-toolkiteno-update-agent branch from 304e5a1 to e5ac49f Compare June 19, 2024 21:54

misspia-cohere requested a deployment to development June 19, 2024 21:54 — with GitHub Actions Waiting

misspia-cohere commented Jun 19, 2024

View reviewed changes

src/interfaces/coral_web/src/components/Agents/AgentForm.tsx Show resolved Hide resolved

wujessica approved these changes Jun 20, 2024

View reviewed changes

knajjars reviewed Jun 20, 2024

View reviewed changes

src/interfaces/coral_web/src/components/Agents/UpdateAgentDrawer.tsx Outdated Show resolved Hide resolved

knajjars reviewed Jun 20, 2024

View reviewed changes

src/interfaces/coral_web/src/components/Agents/UpdateAgentDrawer.tsx Outdated Show resolved Hide resolved

knajjars reviewed Jun 20, 2024

View reviewed changes

src/interfaces/coral_web/src/components/Conversation/Header.tsx Show resolved Hide resolved

knajjars reviewed Jun 20, 2024

View reviewed changes

src/interfaces/coral_web/src/components/Agents/AgentForm.tsx Show resolved Hide resolved

knajjars mentioned this pull request Jun 20, 2024

fix(toolkit): Address code feedback + improvements #249

Merged

knajjars approved these changes Jun 20, 2024

View reviewed changes

fix(toolkit): Address code feedback + improvements (#249)

627883f

address code feedback improvements

knajjars had a problem deploying to development June 20, 2024 13:42 — with GitHub Actions Failure

Merge branch 'main' into pia/tlk-682-toolkiteno-update-agent

c2774e9

misspia-cohere temporarily deployed to development June 20, 2024 14:14 — with GitHub Actions Inactive

misspia-cohere merged commit fa78ff9 into main Jun 20, 2024
3 checks passed

misspia-cohere deleted the pia/tlk-682-toolkiteno-update-agent branch June 20, 2024 14:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

coral-web: update assistant #248

coral-web: update assistant #248

misspia-cohere commented Jun 19, 2024 •

edited by cohere-pr-pal bot

Loading

knajjars commented Jun 20, 2024

coral-web: update assistant #248

coral-web: update assistant #248

Conversation

misspia-cohere commented Jun 19, 2024 • edited by cohere-pr-pal bot Loading

Update Agent Functionality

Agent Left Panel

Other Changes

knajjars commented Jun 20, 2024

misspia-cohere commented Jun 19, 2024 •

edited by cohere-pr-pal bot

Loading