Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: List Assistants returned from API #242

Merged
merged 2 commits into from
Jun 19, 2024
Merged

feat: List Assistants returned from API #242

merged 2 commits into from
Jun 19, 2024

Conversation

knajjars
Copy link
Collaborator

@knajjars knajjars commented Jun 19, 2024 •
edited by cohere-pr-pal bot
Loading

Screen.Recording.2024-06-19.at.2.25.38.PM.mov

Closes OS-2157

AI Description

This PR makes changes to the AgentsList and DiscoverAgentCard components, and introduces a new BaseAgentProps type.

  • The AgentsList component has removed the HR Policy Advisor and Financial Advisor cards.
  • The DiscoverAgentCard component now includes an isBaseAgent prop, and the description prop is now optional.
  • The Welcome component now includes a new isBaseAgent prop, and the show prop has been updated to accept the isBaseAgent prop.
  • The BaseAgentProps type has been introduced, which includes the isBaseAgent prop.
  • The AgentProps type has been updated to include the isBaseAgent prop, which is now optional.
  • The useEffect hook has been added to update the filteredAgents state based on the filterText state.
  • The useDebouncedState hook has been added to debounce the filterText input and update the filteredAgents state accordingly.
  • The getColor function has been updated to accept an additional options parameter, which includes a background property to specify whether a background or text color should be returned.

@knajjars knajjars changed the base branch from main to pia/os-2100-toolkiteno-create-agent June 19, 2024 12:33
misspia-cohere
misspia-cohere approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@misspia-cohere misspia-cohere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicee 🙌

src/interfaces/coral_web/src/components/Conversation/MessagingContainer.tsx Outdated Show resolved Hide resolved
@knajjars @misspia-cohere
Update src/interfaces/coral_web/src/components/Conversation/Messaging…
6d63502 
…Container.tsx

Co-authored-by: misspia-cohere <140425731+misspia-cohere@users.noreply.github.com>
@knajjars knajjars merged commit 369eec3 into pia/os-2100-toolkiteno-create-agent Jun 19, 2024
1 of 2 checks passed
@knajjars knajjars deleted the khalil/list-agents branch June 19, 2024 15:10
misspia-cohere added a commit that referenced this pull request Jun 19, 2024
@misspia-cohere @knajjars
coral-web: create agent + agent base form (#212)
b0cd586 
* create new agent form

* render agents list

* link back to base agent page

* perform post submission actions

* move input labels outside of input borders

* move submit button

* gen client

* factor out agent base form

* use default content type

* list custom agents

* check if agent name is unique

* and deployment + env variables to agent form

* add deployments

* clean up

* add submit modal

* push to new agent page on create success

* only show available deployments

* remove deployments dropdown

* feat: List Assistants returned from API (#242)

* feat: list agents from BE

* Update src/interfaces/coral_web/src/components/Conversation/MessagingContainer.tsx

Co-authored-by: misspia-cohere <140425731+misspia-cohere@users.noreply.github.com>

---------

Co-authored-by: misspia-cohere <140425731+misspia-cohere@users.noreply.github.com>

* nits

---------

Co-authored-by: Khalil Najjar <knajjars@gmail.com>
sanal-cohere pushed a commit that referenced this pull request Jun 21, 2024
@misspia-cohere @knajjars @sanal-cohere
coral-web: create agent + agent base form (#212)
1e74e16 
* create new agent form

* render agents list

* link back to base agent page

* perform post submission actions

* move input labels outside of input borders

* move submit button

* gen client

* factor out agent base form

* use default content type

* list custom agents

* check if agent name is unique

* and deployment + env variables to agent form

* add deployments

* clean up

* add submit modal

* push to new agent page on create success

* only show available deployments

* remove deployments dropdown

* feat: List Assistants returned from API (#242)

* feat: list agents from BE

* Update src/interfaces/coral_web/src/components/Conversation/MessagingContainer.tsx

Co-authored-by: misspia-cohere <140425731+misspia-cohere@users.noreply.github.com>

---------

Co-authored-by: misspia-cohere <140425731+misspia-cohere@users.noreply.github.com>

* nits

---------

Co-authored-by: Khalil Najjar <knajjars@gmail.com>
sanal-cohere added a commit that referenced this pull request Jun 21, 2024
@sanal-cohere @wujessica
@knajjars @lusmoura @tomtobac @tianjing-li @misspia-cohere @EugeneLightsOn @scott-cohere @BeatrixCohere @malexw
Adding Compass Tool (#240)
0c5db02 
* Initial commit for Compass Tool

* coral-web: update first turn suggestions (#225)

* Addressed comments on the previous commit

* Added custom_context to parse and filters to search

* Formatting changes

* feat(assistant): Update conversation header (#229)

* feat(assistant): Update conversation header

* feat(assistant): Update conversation header

* update tooltip

* fix IconButton import

* Setup: fix dependencies (#243)

* feat(toolkit): show conversation list on with agents list (#231)

* Setup: remove redundant dependency (#244)

* Improve Auth guide (#235)

improve auth guide

* coral-web: create agent + agent base form (#212)

* create new agent form

* render agents list

* link back to base agent page

* perform post submission actions

* move input labels outside of input borders

* move submit button

* gen client

* factor out agent base form

* use default content type

* list custom agents

* check if agent name is unique

* and deployment + env variables to agent form

* add deployments

* clean up

* add submit modal

* push to new agent page on create success

* only show available deployments

* remove deployments dropdown

* feat: List Assistants returned from API (#242)

* feat: list agents from BE

* Update src/interfaces/coral_web/src/components/Conversation/MessagingContainer.tsx

Co-authored-by: misspia-cohere <140425731+misspia-cohere@users.noreply.github.com>

---------

Co-authored-by: misspia-cohere <140425731+misspia-cohere@users.noreply.github.com>

* nits

---------

Co-authored-by: Khalil Najjar <knajjars@gmail.com>

* Propagate should_store logic to the File upload logic (#247)

should_store logic to the attach_files_to_messages

* [backend] passing in agent when calling streaming chat (#237)

* initial chat changes

* need to test

* done

* Remove old test

* default model for agents right now

* Organizations DB models, CRUD and tests   (#238)

* Organizations initial commit

* Organizations initial commit

* Organizations initial commit - sync main

* Organizations initial commit - sync main - blacked

* Organizations initial commit - sync main - lint

* Organizations initial commit - sync main - tests

* Organizations initial commit - sync main - tests

* Organizations initial commit - review fixes

* Organizations initial commit - review fixes

* Split up display name and name for Tools  (#241)

* CHange

* change

* coral-web: update assistant (#248)

* create new agent form

* render agents list

* link back to base agent page

* perform post submission actions

* move input labels outside of input borders

* move submit button

* gen client

* factor out agent base form

* check if agent name is unique

* and deployment + env variables to agent form

* add deployments

* clean up

* remove deployments dropdown

* init agent page

* create agent drawer

* use agent form

* add update agent request

* add get agent request

* fix rebase errors

* remove model from agent form

* add agent drawer to conversation

* remove unused componenets

* use new agent name for update success message

* fix(toolkit): Address code feedback + improvements (#249)

address code feedback improvements

---------

Co-authored-by: Khalil Najjar <knajjars@gmail.com>

* feat(toolkit): add/remove recently used agents (#250)

* feat(toolkit): add/remove recently used agents

* merge main

* Add a walkthrough guide of the toolkit  (#251)

* GUide

* Chang

* Change

* Change

* Update docs/walkthrough/walkthrough.md

Co-authored-by: Luísa Moura <luisa@cohere.com>

* Update walkthrough.md

---------

Co-authored-by: Luísa Moura <luisa@cohere.com>

* coral-web: fix agent info panel opening by default (#253)

cast isEditAgentPanelOpen to boolean

* [backend] enforce agent update with user-id (#246)

* updates

* remove client changes

* remove logs

* use better header user id check

* fix validators

* typo

* Metrics: add middleware (#185)

* Metrics: add middleware

* add chat calls

* merge

* lint

* make it async

* add user id

* add more fields

* add retry and duration

* add meta

* comments

* fix tests

* improve error handling

* rename fields

* match spec

* comments

* clean code

* only create loop when theres endpoint

* add assistant id to chat

* feat(toolkit): show assistant welcome message (#255)

* feat(toolkit): show assistant welcome message

* feat(toolkit): show assistant welcome message

* frontend: Login, logout, and account creation (#179)

* add login page components

* Add Register page and hooks for auth

* Add the register page and connect all the frontend elements

* Redirect to /login if the token expires and clean up some console errors

* Add error messages for failed logins

* frontend: Add Single Sign-on to Toolkit (#227)

* Add Google SSO login plus OpenID components

* Dynamically set SSO login buttons and show or hide username and password based on auth_strategies

---------

Co-authored-by: Tianjing Li <tianjinglimail@gmail.com>

* fix startup event

* Fix build errors and update the API client

* Fix tests by adding missing env vars

Add test OIDC_WELL_KNOWN_ENDPOINT var to fixtures

* Add a walkthrough guide of the toolkit  (#251)

* GUide

* Chang

* Change

* Change

* Update docs/walkthrough/walkthrough.md

Co-authored-by: Luísa Moura <luisa@cohere.com>

* Update walkthrough.md

---------

Co-authored-by: Luísa Moura <luisa@cohere.com>

* coral-web: fix agent info panel opening by default (#253)

cast isEditAgentPanelOpen to boolean

* [backend] enforce agent update with user-id (#246)

* updates

* remove client changes

* remove logs

* use better header user id check

* fix validators

* typo

* Metrics: add middleware (#185)

* Metrics: add middleware

* add chat calls

* merge

* lint

* make it async

* add user id

* add more fields

* add retry and duration

* add meta

* comments

* fix tests

* improve error handling

* rename fields

* match spec

* comments

* clean code

* only create loop when theres endpoint

* add assistant id to chat

* feat(toolkit): show assistant welcome message (#255)

* feat(toolkit): show assistant welcome message

* feat(toolkit): show assistant welcome message

---------

Co-authored-by: misspia-cohere <pia@cohere.com>
Co-authored-by: Tianjing Li <tianjinglimail@gmail.com>
Co-authored-by: Beatrix De Wilde <128378696+BeatrixCohere@users.noreply.github.com>
Co-authored-by: Luísa Moura <luisa@cohere.com>
Co-authored-by: misspia-cohere <140425731+misspia-cohere@users.noreply.github.com>
Co-authored-by: Scott <146760070+scott-cohere@users.noreply.github.com>
Co-authored-by: Khalil Najjar <knajjars@gmail.com>

* fix(toolkit): UX/UI improvements (#257)

* Add error troubleshooting (#262)

* Update chat.py

---------

Co-authored-by: Jessica Wu <jessica@cohere.ai>
Co-authored-by: Khalil Najjar <knajjars@gmail.com>
Co-authored-by: Luísa Moura <luisa@cohere.com>
Co-authored-by: Tomeu <tomeu@cohere.com>
Co-authored-by: Tianjing Li <tianjinglimail@gmail.com>
Co-authored-by: misspia-cohere <140425731+misspia-cohere@users.noreply.github.com>
Co-authored-by: Eugene P <144219719+EugeneLightsOn@users.noreply.github.com>
Co-authored-by: Scott <146760070+scott-cohere@users.noreply.github.com>
Co-authored-by: Beatrix De Wilde <128378696+BeatrixCohere@users.noreply.github.com>
Co-authored-by: Alex W <alex@blinkenlights.ca>
Co-authored-by: misspia-cohere <pia@cohere.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misspia-cohere misspia-cohere misspia-cohere approved these changes

@EugeneLightsOn EugeneLightsOn Awaiting requested review from EugeneLightsOn

@malexw malexw Awaiting requested review from malexw

@scottmx81 scottmx81 Awaiting requested review from scottmx81

@tianjing-li tianjing-li Awaiting requested review from tianjing-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knajjars @misspia-cohere