-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.2.0 changes #47
Conversation
kavinagrawalcohesity
commented
May 11, 2024
•
edited
Loading
edited
- pip8, pylint, pslint and validate-modules issues resolved.
- ansible core minimum version changed to 2.15
- requests min version changed to 2.15.0 for git checks
- Changed docs link to reflect ansible core minimum of 8.0
- New release version 1.2.0
- Updated ansible docs
bba3dd8
to
048f423
Compare
028449e
to
1b3cb2b
Compare
@@ -28,8 +28,8 @@ collections: | |||
- cohesity.dataprotect | |||
``` | |||
# Requirements | |||
- ansible version >= 2.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't that a big jump from 2.9 to 8?
Whats the latest ansible release available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs was not updated from a long time here.
@@ -680,7 +683,7 @@ def unregister_source(module, self): | |||
headers = { | |||
"Accept": "application/json", | |||
"Authorization": "Bearer " + token, | |||
"user-agent": "cohesity-ansible/v1.1.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we define a constance somewhere to track the user agent value and refer to the constant value here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do that defeinitely, but currently trying to resolve several lint issues received in this build. This can be done separately as part of different PR.
LGTM , go ahead and make a push to redhat repo with 0 lint errors. |