Release v1.2.0 changes #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kavinagrawalcohesity
commented
May 11, 2024
•
kavinagrawalcohesity
commented
- pip8, pylint, pslint and validate-modules issues resolved.
- ansible core minimum version changed to 2.15
- requests min version changed to 2.15.0 for git checks
- Changed docs link to reflect ansible core minimum of 8.0
- New release version 1.2.0
- Updated ansible docs
kavinagrawalcohesity
force-pushed
the
ansible-version-upgrade
branch
from
bba3dd8
to
048f423
Compare
kavinagrawalcohesity
force-pushed
the
ansible-version-upgrade
branch
from
028449e
to
1b3cb2b
Compare
| @@ -28,8 +28,8 @@ collections: | |||
| - cohesity.dataprotect | |||
| ``` | |||
| # Requirements | |||
| - ansible version >= 2.9 | |||
There was a problem hiding this comment.
Isn't that a big jump from 2.9 to 8?
Whats the latest ansible release available?
There was a problem hiding this comment.
The docs was not updated from a long time here.
| @@ -680,7 +683,7 @@ def unregister_source(module, self): | |||
| headers = { | |||
| "Accept": "application/json", | |||
| "Authorization": "Bearer " + token, | |||
| "user-agent": "cohesity-ansible/v1.1.9", | |||
There was a problem hiding this comment.
Can we define a constance somewhere to track the user agent value and refer to the constant value here?
There was a problem hiding this comment.
We can do that defeinitely, but currently trying to resolve several lint issues received in this build. This can be done separately as part of different PR.
kavinagrawalcohesity
changed the title
|
LGTM , go ahead and make a push to redhat repo with 0 lint errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.