Skip to content
This repository has been archived by the owner on Oct 19, 2022. It is now read-only.

Remove unneeded events / states from BloCs #520

Open
Boehrsi opened this issue Apr 8, 2020 · 1 comment
Open

Remove unneeded events / states from BloCs #520

Boehrsi opened this issue Apr 8, 2020 · 1 comment
Labels
tech debt Technical tickets without user visible impact

Comments

@Boehrsi
Copy link
Collaborator

Boehrsi commented Apr 8, 2020

Is your feature request related to a problem? Please describe.

In the beginning we weren't aware of yield* and created a lot of useless event / state transitions (as seen here https://github.com/open-xchange/ox-coi/blob/develop/lib/src/contact/contact_change_bloc.dart).

Describe the solution you'd like

Instead of adding events, which directly map to new state, e.g. if a method in a BloC is finished, we should just directly return the new state and use it via yield*. Compare https://github.com/open-xchange/ox-coi/blob/develop/lib/src/contact/contact_list_bloc.dart

Internal Bug Tracker.

@Boehrsi Boehrsi added the tech debt Technical tickets without user visible impact label Apr 8, 2020
@florianhaar florianhaar self-assigned this Jun 11, 2020
@Boehrsi
Copy link
Collaborator Author

Boehrsi commented Jun 15, 2020

Will be merged after the final beta-7 release. As this could introduce side effects.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tech debt Technical tickets without user visible impact
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants