Skip to content
This repository has been archived by the owner on Oct 19, 2022. It is now read-only.

Remove unneeded events / states from BloCs #520 #610

Closed
wants to merge 1 commit into from

Conversation

florianhaar
Copy link
Contributor

Link to the given issue
Fixes #520

Describe what the problem was / what the new feature is
In the beginning we weren't aware of yield* and created a lot of useless event / state transitions

Describe your solution
Removed the useless events and used the yield*.

Additional context

  • Added more *Async suffixes
  • Added Future<void> and await to async methods

@florianhaar florianhaar requested a review from Boehrsi June 12, 2020 09:32
Copy link
Collaborator

@Boehrsi Boehrsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the first look, but some functionality is broken. Tests showed problem with security_settings and profile screen. Please have a look.

@Boehrsi Boehrsi added the warning Needs further actions label Jun 15, 2020
@Boehrsi
Copy link
Collaborator

Boehrsi commented Jun 15, 2020

Added the warning label as this PR shouldn't be merged until the final beta-7 release is done.

@Boehrsi Boehrsi closed this Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
warning Needs further actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unneeded events / states from BloCs
2 participants