Skip to content
This repository has been archived by the owner on Oct 19, 2022. It is now read-only.

OT-717: Unreadable Status Bar #511

Merged
merged 4 commits into from
Apr 8, 2020
Merged

Commits on Apr 6, 2020

  1. OT-717: Unreadable Status Bar

    Fixes #449
    
    BUGFIX
    * Fixes a bug that happens on switching between Light and Dark mode, which results in an unreadable system status bar
    
    ADDITIONS & CHANGES
    * Adds a new `ThemeKey` enum value `system`
    * Changes setting for Light/Dark mode in user profile by removing the switch
    * Adds a new screen for switching application appearance to `Light`/`Dark` or `System`
    * Refactors all `ThemeKey` enum values from UPPERCASE to lowercase
    * Adds `vibrateLight` method for haptic feedback when user changes appearance
    * Adds new assets for all three theme states: Light, Dark, System
    * Cleans up code
    
    ADDITIONAL NOTES
    * Adds `activeColor` setting to all used `Switch.adaptive` widgets with the value of `CustomTheme.of(context).accent`, because on iOS they had the default green color which doesn't fit our application color theme.
    * Adds `Preference` class with just two static methods `set({@required value, @required String forKey})` and `value({@required String forKey})` for convenience and better readability
    * Adds static getter/setter on `Preference` class for easier handling of preference values and better readability (NOTE: Should be discussed if we adopt this system overall)
      So instead of calling:
      ```
       setPreference(preferenceAppThemeKey, ThemeKey.light.toString());
      ```
      we can call:
      ```
      Preference.themeKey = ThemeKey.light.toString();
      ```
    Frank Gregor committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    2af2364 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'develop' into OT-717_UnreadableStatusBar

    # Conflicts:
    #	lib/main.dart
    Frank Gregor committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    57a68af View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. * Fixes broken changes after Merge commit with develop

    * Adds missing line break after last line of code
    * Fixes bug on using describeEnum(..)
    * Updates assets to new versions
    * Adapts corner radius at image border according Cornelius' request
    * adapts UI according to Cornelius' request
    * fixes Image height
    * removes code regarding convenience class 'Preference'
    Frank Gregor committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    9e59ede View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2020

  1. Review changes

    Boehrsi committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    d2d0776 View commit details
    Browse the repository at this point in the history