This repository has been archived by the owner on Oct 19, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #449 BUGFIX * Fixes a bug that happens on switching between Light and Dark mode, which results in an unreadable system status bar ADDITIONS & CHANGES * Adds a new `ThemeKey` enum value `system` * Changes setting for Light/Dark mode in user profile by removing the switch * Adds a new screen for switching application appearance to `Light`/`Dark` or `System` * Refactors all `ThemeKey` enum values from UPPERCASE to lowercase * Adds `vibrateLight` method for haptic feedback when user changes appearance * Adds new assets for all three theme states: Light, Dark, System * Cleans up code ADDITIONAL NOTES * Adds `activeColor` setting to all used `Switch.adaptive` widgets with the value of `CustomTheme.of(context).accent`, because on iOS they had the default green color which doesn't fit our application color theme. * Adds `Preference` class with just two static methods `set({@required value, @required String forKey})` and `value({@required String forKey})` for convenience and better readability * Adds static getter/setter on `Preference` class for easier handling of preference values and better readability (NOTE: Should be discussed if we adopt this system overall) So instead of calling: ``` setPreference(preferenceAppThemeKey, ThemeKey.light.toString()); ``` we can call: ``` Preference.themeKey = ThemeKey.light.toString(); ```
# Conflicts: # lib/main.dart
florianhaar
suggested changes
Apr 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
phranck
force-pushed
the
OT-717_UnreadableStatusBar
branch
2 times, most recently
from
April 7, 2020 10:24
cba61a9
to
ed5a0d9
Compare
@florianhaar @Boehrsi |
* Adds missing line break after last line of code * Fixes bug on using describeEnum(..) * Updates assets to new versions * Adapts corner radius at image border according Cornelius' request * adapts UI according to Cornelius' request * fixes Image height * removes code regarding convenience class 'Preference'
phranck
force-pushed
the
OT-717_UnreadableStatusBar
branch
from
April 7, 2020 13:38
ed5a0d9
to
9e59ede
Compare
Notes / stuff to check tomorrow for /me:
|
Boehrsi
approved these changes
Apr 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will check functionality and the framework problem tomorrow morning. Also have some questions / ideas we can talk about tomorrow (see my previous comment).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #449
BUGFIX
ADDITIONS & CHANGES
ThemeKey
enum valuesystem
Light
/Dark
orSystem
ThemeKey
enum values from UPPERCASE to lowercasevibrateLight
method for haptic feedback when user changes appearancestringValue
forenum ThemeKey
to get a string of the enum value onlyADDITIONAL NOTES
activeColor
setting to all usedSwitch.adaptive
widgets with the value ofCustomTheme.of(context).accent
, because on iOS they had the default green color which doesn't fit our application color theme (unrelated regarding the topic of the ticket).Removed after first discussion
AddsPreference
class with just two static methodsset({@required value, @required String forKey})
andvalue({@required String forKey})
for convenience and better readabilityAdds static getter/setter onPreference
class for easier handling of preference values and better readability (NOTE: Should be discussed if we adopt this system overall)So instead of calling: