Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write spec test to cover not covered Ruby files (up 80%) #10

Closed
cardil opened this issue Sep 25, 2015 · 1 comment
Closed

Write spec test to cover not covered Ruby files (up 80%) #10

cardil opened this issue Sep 25, 2015 · 1 comment
Assignees
@Cosaquee
Labels
enhancement tests
Milestone
v1.0.3 - RubyCake

Comments

@cardil
Copy link
Collaborator

cardil commented Sep 25, 2015

Currentlly only those Ruby files are covered by spec tests:

lib/facter/jboss_running.rb
lib/puppet/provider/jboss_jdbcdriver/jbosscli.rb
lib/puppet/provider/jboss_datasource/jbosscli.rb
lib/puppet/provider/jbosscli.rb
lib/facter/jboss_fullconfig.rb
lib/facter/jboss_configfile.rb
lib/puppet/parser/functions/jboss_to_bool.rb
lib/puppet/parser/functions/jboss_to_i.rb
lib/puppet/parser/functions/jboss_to_s.rb
lib/puppet/type/jboss_datasource.rb
lib/puppet/type/jboss_jdbcdriver.rb
lib/puppet_x/coi/jboss/configuration.rb
lib/puppet_x/coi/jboss/functions/jboss_to_bool.rb
lib/puppet_x/coi/jboss/functions/jboss_to_i.rb
lib/puppet_x/coi/jboss/functions/jboss_to_s.rb
lib/puppet_x/coi/jboss/provider/datasource/post_wildfly_provider.rb
lib/puppet_x/coi/jboss/provider/datasource/pre_wildfly_provider.rb

Does files needs to be covered:

lib/puppet/type/jboss_resourceadapter.rb
lib/puppet/type/jboss_confignode.rb
lib/puppet/type/jboss_jmsqueue.rb
lib/puppet/type/jboss_securitydomain.rb
lib/puppet/type/jboss_deploy.rb
lib/puppet/parser/functions/jboss_short_version.rb
lib/puppet/parser/functions/jboss_basename.rb
lib/puppet/parser/functions/jboss_type_version.rb
lib/puppet/parser/functions/jboss_hash_setvalue.rb
lib/puppet/parser/functions/jboss_dirname.rb
lib/puppet/provider/jboss_resourceadapter/jbosscli.rb
lib/puppet/provider/jboss_confignode/jbosscli.rb
lib/puppet/provider/jboss_jmsqueue/jbosscli.rb
lib/puppet/provider/jboss_securitydomain/jbosscli.rb
lib/puppet/provider/jboss_deploy/jbosscli.rb
@cardil cardil added this to the v1.0.1 - MintyFrost milestone Sep 25, 2015
cardil pushed a commit that referenced this issue Sep 25, 2015
Enh #10: Partial tests for confignode and deploy types
037cba6
@cardil cardil mentioned this issue Sep 25, 2015
Merged
@cardil cardil modified the milestones: v1.0.1 - MintyFrost, v1.0.2 - RubyCake Oct 22, 2015
@cardil cardil changed the title Write spec test to cover not covered Ruby files Write spec test to cover not covered Ruby files (up 80%) Dec 4, 2015
Cosaquee pushed a commit that referenced this issue Dec 21, 2015
#10 jboss_resourceadapter spec
966f4e5
Cosaquee pushed a commit that referenced this issue Dec 21, 2015
#10 Tests for jmsqueue and security domain
39f95a5
Cosaquee pushed a commit that referenced this issue Dec 21, 2015
#10 jboss_short_version number of arguments check and tests
ae7d8ec
Cosaquee pushed a commit that referenced this issue Dec 22, 2015
#10 fixes for bug in jboss_basename and tests
bea75c5
Cosaquee pushed a commit that referenced this issue Dec 22, 2015
#10 logic of jboss_dirname now in puppet_x + tests
7b15dff
Cosaquee pushed a commit that referenced this issue Dec 22, 2015
#10 raise error if args.size != 3 and tests
7e7e577
Cosaquee pushed a commit that referenced this issue Dec 22, 2015
#10 fix
62c9c24
Cosaquee pushed a commit that referenced this issue Dec 22, 2015
#10 jboss_type_version moved to puppet_x + tests
0f60e62
Cosaquee pushed a commit that referenced this issue Dec 22, 2015
#10 jboss_short_version tests
fef96bf
therek pushed a commit that referenced this issue Dec 31, 2015
#10 Tests for jboss_deploy and jboss_jmsqueue
316b7c2
Cosaquee pushed a commit that referenced this issue Jan 4, 2016
#10 tests for jboss_dirname
e40b61c
Cosaquee pushed a commit that referenced this issue Jan 5, 2016
#10 more tests for jboss_fullconfig
ed5b886
Cosaquee pushed a commit that referenced this issue Jan 5, 2016
#10 fix message in jboss_fullconfig_spec
42849df
Cosaquee pushed a commit that referenced this issue Jan 5, 2016
#10 workaround for ruby1.8 with hashes
6987456
Cosaquee pushed a commit that referenced this issue Jan 7, 2016
#10 workaround for ruby1.8 with hashes, tests for securitydomain
606b41d
Cosaquee pushed a commit that referenced this issue Jan 7, 2016
#10 test for destroy method in securitydomain
f1cf025
Cosaquee pushed a commit that referenced this issue Jan 7, 2016
#10 securitydomain in puppet_x
46a9516
Cosaquee pushed a commit that referenced this issue Jan 14, 2016
#10 tests for securitydomain cli
f3dda70
Cosaquee pushed a commit that referenced this issue Jan 14, 2016
#10 tests for securitydomain cli 2
ced19fd
Cosaquee pushed a commit that referenced this issue Jan 15, 2016
#10 jboss_deploy in puppet_x and tests for create and destroy
1b6aaf0
@Cosaquee Cosaquee mentioned this issue Jan 15, 2016
Closed
Cosaquee pushed a commit that referenced this issue Jan 18, 2016
#10 jboss_deploy tests
a5f3300
Cosaquee pushed a commit that referenced this issue Jan 18, 2016
#10 delete pry binding in code
c2aadbd
Cosaquee pushed a commit that referenced this issue Jan 20, 2016
#10 jboss_confignode in puppet_x
7b32643
Cosaquee pushed a commit that referenced this issue Jan 20, 2016
#10 enhancement in contribution guidelines
3032a82
Cosaquee pushed a commit that referenced this issue Jan 20, 2016
#10 configcode tests
8355b4a
Cosaquee pushed a commit that referenced this issue Jan 20, 2016
#10 test will pass on osx machines
d4674c5
Cosaquee pushed a commit that referenced this issue Jan 20, 2016
#10 tests for security node
a6f936e
cardil pushed a commit that referenced this issue Jan 20, 2016
#10 Editor config for various IDEs
c6e0a68
cardil pushed a commit that referenced this issue Jan 20, 2016
Enh #10: Use central package module structure
4806192
cardil pushed a commit that referenced this issue Jan 20, 2016
Enh #10: Test for relative_require
7482004
@cardil cardil added the tests label Jan 22, 2016
@Cosaquee Cosaquee mentioned this issue Jan 22, 2016
Open
Cosaquee pushed a commit that referenced this issue Jan 22, 2016
#10 jmsqueue in puppet_x and tests for create and destroy
1e8c1dd
Cosaquee pushed a commit that referenced this issue Jan 22, 2016
#10 tests for jmsqueue
ed5af80
Cosaquee pushed a commit that referenced this issue Jan 22, 2016
#10 correct files
8960d3f
cardil pushed a commit that referenced this issue Jan 22, 2016
Enh #10: Fixes for Ruby 1.8
3bc0276 
Also fixing couple of errors and copy-pastes by mister @Cosaque :-P
cardil pushed a commit that referenced this issue Jan 22, 2016
Enh #10: Fixes for Ruby 1.8
139db38 
Also fixing couple of errors and copy-pastes by mister @Cosaquee :-P
@cardil cardil mentioned this issue Jan 22, 2016
Merged
cardil added a commit that referenced this issue Jan 22, 2016
@cardil
Enh #10: Fix for datasource options munging, bug from #43 and #9
94cccf3
cardil pushed a commit that referenced this issue Jan 26, 2016
Fighting with various technical dept issues and correct way to use ab…
774f382 
…sent-like and hashlike values for #10
cardil pushed a commit that referenced this issue Jan 26, 2016
Fighting with various technical dept issues and correct way to use ab…
66f0f9a 
…sent-like and hashlike values for #10
Cosaquee pushed a commit that referenced this issue Jan 26, 2016
#10 minor changes is tests directory
d7f8567
@cardil cardil mentioned this issue Jan 27, 2016
Closed
cardil pushed a commit that referenced this issue Jan 29, 2016
Last minor minor fixes to #10
6a170be
cardil added a commit that referenced this issue Jan 29, 2016
@cardil
Merge pull request #46 from coi-gov-pl/feature/enh-10-cover-not-covered
5633b79 
Enhancement #10: Raising coverage to more then 80% and cover all Ruby source files
@cardil
Copy link
Collaborator Author

cardil commented Jan 29, 2016

Fixed by merging PR #46

@cardil cardil closed this as completed Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cosaquee Cosaquee

Labels
enhancement tests
Projects
None yet
Milestone
v1.0.3 - RubyCake
Development

No branches or pull requests
2 participants
@cardil @Cosaquee