Enhancement #10: Raising coverage to more then 80% and cover all Ruby source files

[cardil]

This PR is huge but needs to be like this to actively fight back technical dept.

Good work mister @Cosaquee!

But, this needs to be explicitly tested - also manually on real machines, before merge!

[cardil]

This should fix enhancement #10

[Cosaquee]

👍 👯

[cardil]

Tip for manual testing for @coi-gov-pl/jboss-puppet-team:

Puppet 3.7.4 - inside cointainer docker run -h wfly.localdomain -it --rm devopsil/puppet:3.7.4:

yum install -y tar git
puppet module install coi/jboss
rm -rf /etc/puppet/modules/jboss
cd /etc/puppet/modules
git clone https://github.com/coi-gov-pl/puppet-jboss.git jboss
cd jboss
git checkout feature/enh-10-cover-not-covered

and do some serious tests with tests/*.pp files:

puppet apply tests/domain/controller.pp
puppet apply tests/domain/controller.pp
puppet apply tests/domain/node.pp
puppet apply tests/domain/node.pp
# [..]

Do it also for Puppet 2.7.22 with cointainer docker run -h wfly.localdomain -it --rm devopsil/puppet:2.7.25

For 2.7.x run also before testing:

yum install -y hiera-puppet

Run compliance suites for COI projects!

[Cosaquee]

I will run tests suites.

[cardil]

Unfortunately commit 8f06566 seems to not work as expected (should fix #50).

We need to write some spec test case for that to be explicitly tested

[cardil]

I like to confirm that those changes are 100% compatible with compliance suites for COI projects.

Todo before merge:

• write spec test to replicate Error when testing interface.pp #50
• correct code change from 8f06566

After that reopen this PR

[cardil]

b280c37: Typo misled @Cosaquee and resulted in incorrect bug report #50

It should be okey now to be reviewed last time, before merge. Please approve @coi-gov-pl/jboss-puppet-team

[therek]

Looks good to me 👍

[cardil]

Merge fixes #10