Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos #314

Closed
SnarkBoojum opened this issue Jun 19, 2020 · 2 comments
Closed

Typos #314

SnarkBoojum opened this issue Jun 19, 2020 · 2 comments

Comments

@SnarkBoojum
Copy link

I'm taking over the maintenance of Cbc in Debian, and the tools detected a few typos. I'll provide a patch later today.

@SnarkBoojum
Copy link
Author

Description: fix obvious typos in the code
Author: Julien Puydt
Forwarded: https://github.com/coin-or/Cbc/issues/314

--- coinor-cbc.orig/Cbc/examples/modk.c
+++ coinor-cbc/Cbc/examples/modk.c
@@ -155,7 +155,7 @@
             }
           default:
             {
-              fprintf( stderr, "unknow sense!");
+              fprintf( stderr, "unknown sense!");
               abort();
             }
         }
--- coinor-cbc.orig/Cbc/src/CbcHeuristicDW.cpp
+++ coinor-cbc/Cbc/src/CbcHeuristicDW.cpp
@@ -457,7 +457,7 @@
     }
   }
   if (numberNoMaster) {
-    sprintf(dwPrint, "*** %d blocks have no elements in master - can be solved seperately",
+    sprintf(dwPrint, "*** %d blocks have no elements in master - can be solved separately",
       numberNoMaster);
     model_->messageHandler()->message(CBC_FPUMP1, model_->messages())
       << dwPrint
--- coinor-cbc.orig/Cbc/src/Cbc_C_Interface.cpp
+++ coinor-cbc/Cbc/src/Cbc_C_Interface.cpp
@@ -1376,7 +1376,7 @@
     rowLB = rhs;
     break;
   default:
-    fprintf(stderr, "unknow row sense %c.", toupper(sense));
+    fprintf(stderr, "unknown row sense %c.", toupper(sense));
     abort();
   }
   solver->addRow(nz, cols, coefs, rowLB, rowUB);
@@ -1735,7 +1735,7 @@
     orc.setLb(rhs);
     break;
   default:
-    fprintf(stderr, "unknow row sense %c.", toupper(sense));
+    fprintf(stderr, "unknown row sense %c.", toupper(sense));
     abort();
   }
 

(I'm fond of this ticket number!)

@tkralphs
Copy link
Member

First, thanks very much for taking over Cbc on Debian! I've had on my TODO list to find a new maintainer. So wow, the tools actually spell check the strings? That is cool.

FYI, we are currently in the midst of a long transition to modern autotools and there will be some changes coming to the Cbc stack in the next stable versions that you will probably need to be aware of. I'm planning to make a final release 2.10.6 of the current stable version and then will start working on 3.0.

When we make the move to 3.0, it might be good to point to the source archives on Github going forward. For the time being, we'll still archive the source on our own servers, but we've been talking about maybe transitioning away from doing that now that we've moved the source repository itself off of our own servers and onto Github. You may also need to update the repo from the old SVN to Github.

Keep in touch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants