Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bigger buffer for CoinLpIO to allow to store bigger names #83

Open
svigerske opened this issue Mar 2, 2019 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@svigerske
Copy link
Member

svigerske commented Mar 2, 2019

Issue created by migration from Trac.

Original creator: @ycollet

Original creation time: 2014-03-10 09:05:24

CoinLpIO complains when name are longer than 100 chars.
You should either use string instead of chars to store names or use a ifdef to allow to fine tune the maximum size of the buffer like:

#ifndef COIN_LPIO_BUFFER
#define COIN_LPIO_BUFFER 1024
#endif

And use this symbol where the buffer is too small.

@svigerske svigerske added enhancement New feature or request major labels Mar 2, 2019
@svigerske
Copy link
Member Author

svigerske commented Mar 2, 2019

Attachment CoinLpIO.cpp by @ycollet created at 2014-03-10 09:06:03

A first try to allow to set the maximum size of the buffer at compile time.

@svigerske
Copy link
Member Author

CC @ycollet

@svigerske
Copy link
Member Author

Unfortunately, code has been reformatted, which will make it difficult to apply the changes.
Can you create a pull request with respect to the current CoinUtils source for this?

@svigerske svigerske removed the major label Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant