New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use setuptools_scm to determine the version #151
Conversation
ec9713d
to
91b84e4
Compare
Hi @lpsinger , sorry my ignorance, how do I inform the version with setuptools_scm , i.e., before releasing a new version ? |
Just create a git tag. When you build your release (with |
This fixes an issue where cffi was required to build a wheel: $ python setup.py bdist_wheel Traceback (most recent call last): File "setup.py", line 6, in <module> exec(open("mip/constants.py").read(), version_dict) File "<string>", line 4, in <module> ModuleNotFoundError: No module named 'cffi' It should also streamline the process of making a release a tiny bit.
91b84e4
to
b9d688b
Compare
Any update on this? The false cffi build-time dependency is causing some installation issues with certain virtual environment tools (e.g. poetry). |
Thank you! |
Hi @lpsinger , just tagged version 1.13.0 , the version appears as 1.13.1.dev0+gc7c8d6b.d20201122 Could this string be trimmed ? Or it is a good practice to include these additional details ? (for me they do not seem to be relevant) Cheers |
Ops, the problem is bigger than I thought, the string is not accepted as a valid version HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/ |
It looks like you made a tarball before tagging. |
worked, thanks ! |
This fixes an issue where cffi was required to build a wheel: $ python setup.py bdist_wheel Traceback (most recent call last): File "setup.py", line 6, in <module> exec(open("mip/constants.py").read(), version_dict) File "<string>", line 4, in <module> ModuleNotFoundError: No module named 'cffi' It should also streamline the process of making a release a tiny bit.
This fixes an issue where cffi was required to build a wheel:
It should also streamline the process of making a release a tiny bit.