fix: Paymaster Proxy URL #513
Conversation
cpcramer
changed the title
cpcramer
force-pushed
the
paul/test--onchain-kit-paymaster-functionality
branch
2 times, most recently
from
f1fe759
to
e5bcfe6
Compare
cpcramer
changed the title
| const defaultUrl = isLocalEnv ? paymasterURL : `${document.location.origin}/api/paymaster-proxy`; | ||
| // Target the Paymaster directly without a proxy if running on localhost. | ||
| // Use the Paymaster Proxy when deployed. | ||
| const isLocalEnv = process.env.NEXT_PUBLIC_VERCEL_ENV === undefined; |
There was a problem hiding this comment.
What's wrong with isLocal? should we fix that?
There was a problem hiding this comment.
isLocal wasn't working for me. It was always returning that the application was running locally, even when deployed.
There was a problem hiding this comment.
I think that we can just take advantage of the Vercel System Environment Variable
There was a problem hiding this comment.
It actually looked like the issue was with getCurrentEnvironment - a function that isLocal relies on.
There was a problem hiding this comment.
My advice here is, to make sure isLocal() works well. And just use that everywhere.
And avoid doing side solution.
In a few words, improve what we have, and avoid create N+1 solution for the same problem.
There was a problem hiding this comment.
Makes sense! I updated getCurrentEnvironment to have the NEXT_PUBLIC prefix and it now works. I've tested in local and dev!
cpcramer
force-pushed
the
paul/test--onchain-kit-paymaster-functionality
branch
from
99e9a13
to
ea9bd4f
Compare
cpcramer
force-pushed
the
paul/test--onchain-kit-paymaster-functionality
branch
2 times, most recently
from
3fd11d3
to
c00c673
Compare
cpcramer
force-pushed
the
paul/test--onchain-kit-paymaster-functionality
branch
from
c00c673
to
e6ab8fd
Compare
What changed? Why?
We are checking if process.env.NEXT_PUBLIC_VERCEL_ENV is undefined which means that we are on local. Therefore, we will hit our Paymaster directly.
When deployed we are using the System Environment Variable
NEXT_PUBLIC_VERCEL_PROJECT_PRODUCTION_URL.Notes to reviewers
How has it been tested?
Tested locally and in Vercel Dev.