feat: Add onchain kit paymaster utilities #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcramer
force-pushed
the
paul/add-onchain-kit-paymaster-utilities
branch
from
abbc55b
to
1aaacd9
Compare
cpcramer
force-pushed
the
paul/add-onchain-kit-paymaster-utilities
branch
from
9513af6
to
996459a
Compare
cpcramer
commented
Jun 10, 2024
cpcramer
commented
Jun 10, 2024
cpcramer
commented
Jun 10, 2024
cpcramer
commented
Jun 10, 2024
Comment on lines
+8
to
+11
| export const client = createPublicClient({ | ||
| chain: baseSepolia, | ||
| transport: http(), | ||
| }); |
There was a problem hiding this comment.
This is used as the client to pass into isWalletASmartWallet
There was a problem hiding this comment.
I believe we already have a client, no?
There was a problem hiding this comment.
Had to use client rather than paymasterClient because client is created using createPublicClient and is of type PublicClient, which is what isWalletASmartWallet expects.
Maybe we should update isWalletASmartWallet to use createClient rather than createPublicClient from Viem?
There was a problem hiding this comment.
I think that isWalletASmartWallet should continue to use createClient because it is a "public" endpoint that doesn't require authentication to use.
cpcramer
force-pushed
the
paul/add-onchain-kit-paymaster-utilities
branch
from
37cc1f4
to
8bb2c1e
Compare
Zizzamia
reviewed
Jun 11, 2024
Zizzamia
reviewed
Jun 11, 2024
Zizzamia
reviewed
Jun 11, 2024
cpcramer
force-pushed
the
paul/add-onchain-kit-paymaster-utilities
branch
from
8bb2c1e
to
7464c05
Compare
cpcramer
force-pushed
the
paul/add-onchain-kit-paymaster-utilities
branch
from
e51889a
to
f00d066
Compare
Zizzamia
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Add
isValidAAEntrypointandisWalletASmartWalletOnchainKit utilities to thepaymaster proxy.isValidAAEntrypointhttps://onchainkit.xyz/wallet/is-valid-aa-entrypointisWalletASmartWallethttps://onchainkit.xyz/wallet/is-wallet-a-smart-walletUpdate and add unit tests.
Notes to reviewers
How has it been tested?
Tested locally and in Dev.