Fix timer cancellation regression #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antstorm
added
the
sync pending
somic
approved these changes
Aug 12, 2021
antstorm
added
synced
DeRauk
pushed a commit
to DeRauk/cadence-ruby
that referenced
this pull request
Jan 19, 2022
* Fix timer cancellation regression * Bump version to 0.1.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#56 has introduced a regression which would associate timer cancelation request with the timer itself resulting in a non-deterministic replay (attempting to match timer's cancellation with initiation of the timer, which are two separate commands).
It was tested using a sample workflow and a unit spec