This repository has been archived by the owner on Jan 20, 2020. It is now read-only.
CircleCI Build Matrix #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fb55
reviewed
May 14, 2018
| }); | ||
| }); | ||
|
|
||
| server.on('connection', socket => { | ||
| socket.send(JSON.stringify({ product_id: 'BTC-USD' })); | ||
| socket.on('message', () => { |
|
Looks great, thanks a lot! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
lintandprettiersanity test prior to running the standard test suite (for people who might disable theprecommithooks while usinglint-staged).What else do you need to know?
Also fixes existing prettier errors
Also fixes build on Node 6 (timing and
ECONNRESETissues) onOrderbookSyncandWebsocketClientprettieris only run against*.jsfiles, because different npm versions mess with package.json & package-lock.json differently (causing the build to unnecessarily fail on different versions).Related Issues
Screenshots
/cc @fb55