Introduce connectAndSignIn #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangtoven
force-pushed
the
jungho/connect-and-sign-in
branch
from
8fef882
to
7b47c70
Compare
bangtoven
commented
Jun 28, 2023
Comment on lines
+34
to
+43
| RequestEthereumAccountsBaseParams & { | ||
| domain: string; | ||
| aud: string; | ||
| version: string; | ||
| type: string; | ||
| nonce: string; | ||
| iat: string; | ||
| chainId: string; | ||
| statement?: string; | ||
| resources?: string[]; |
There was a problem hiding this comment.
it includes RequestEthereumAccountsBaseParams
bangtoven
commented
Jun 28, 2023
Comment on lines
+29
to
+34
| export type ConnectAndSignInResponse = BaseWeb3Response<{ | ||
| addresses: AddressString[]; | ||
| message: string; | ||
| signature: HexString; | ||
| }>; | ||
|
|
There was a problem hiding this comment.
open to suggestions
bangtoven
commented
Jun 28, 2023
| @@ -858,6 +860,31 @@ export class WalletLinkRelay extends WalletSDKRelayAbstract { | |||
| } | |||
| } | |||
|
|
|||
| // WIP | |||
There was a problem hiding this comment.
having it private for now.
will be exposed as public once it's done.
vishnumad
approved these changes
Jun 28, 2023
| // WIP | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore | ||
| private connectAndSignIn(_params: { |
Merged
bangtoven
added a commit
that referenced
this pull request
Feb 29, 2024
* Introduce connectAndSignIn * simpler * linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How did you test your changes?