MobileRelayUI #904
Merged
MobileRelayUI #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangtoven
commented
Jun 24, 2023
| @@ -45,7 +46,7 @@ export interface CoinbaseWalletSDKOptions { | |||
| /** @optional whether or not to reload dapp automatically after disconnect, defaults to true */ | |||
| reloadOnDisconnect?: boolean; | |||
| /** @optional whether to connect mobile web app via WalletLink, defaults to false */ | |||
| useMobileWalletLink?: boolean; | |||
| enableMobileWalletLink?: boolean; | |||
There was a problem hiding this comment.
avoid confusion as react hook
bangtoven
force-pushed
the
jungho/mobile-redirect
branch
from
a0299df
to
807af54
Compare
bangtoven
commented
Jun 27, 2023
bangtoven
commented
Jun 27, 2023
Comment on lines
98
to
104
| showConnecting(_options: { | ||
| isUnlinkedErrorState?: boolean | undefined; | ||
| onCancel: ErrorHandler; | ||
| onResetConnection: () => void; | ||
| }): () => void { | ||
| return () => {}; // no-op | ||
| } |
There was a problem hiding this comment.
TODO: i might try this thing
bangtoven
commented
Jun 27, 2023
adding RedirectDialog
This reverts commit ff0153d.
bangtoven
commented
Jun 29, 2023
| onButtonClick: () => void; | ||
| }; | ||
|
|
||
| export class RedirectDialog { |
There was a problem hiding this comment.
to show a button in case of redirection getting blocked by browser
bangtoven
commented
Jun 29, 2023
|
|
||
| setTimeout(() => { | ||
| this.redirectToCoinbaseWallet(walletLinkUrl); | ||
| }, 99); |
There was a problem hiding this comment.
before redirecting to cb wallet, technically we should wait for message to be transmitted via websocket. but that's hidden very very deep under rxjs swamp.
tried listening to the rx observable, however i have encountered an issue where the browser seems to restrict calling window.open within the rxjs subscription block.
per some SO posts, it's known that browser blocks web apps to call window.open from rxjs handlers.
so, it just uses timeout here and show a dialog with force redirection just in case.
There was a problem hiding this comment.
is the goal here to auto redirect if the user doesn't click the button?
bangtoven
commented
Jun 29, 2023
| location = window.location; | ||
| } | ||
|
|
||
| const location = getLocation(); |
bangtoven
commented
Jun 29, 2023
| @@ -863,7 +863,7 @@ export class WalletLinkRelay extends WalletSDKRelayAbstract { | |||
| // WIP | |||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | |||
| // @ts-ignore | |||
| private connectAndSignIn(_params: { | |||
| private connectAndSignIn(params: { | |||
There was a problem hiding this comment.
addressing #908 (comment)
cb-jake
reviewed
Jun 29, 2023
cb-jake
reviewed
Jun 29, 2023
packages/wallet-sdk/src/components/RedirectDialog/RedirectDialog.tsx
Outdated
Show resolved
Hide resolved
cb-jake
reviewed
Jun 29, 2023
cb-jake
reviewed
Jun 29, 2023
vishnumad
previously approved these changes
Jun 29, 2023
cb-jake
reviewed
Jun 29, 2023
cb-jake
reviewed
Jun 29, 2023
cb-jake
reviewed
Jun 29, 2023
packages/wallet-sdk/src/components/RedirectDialog/RedirectDialog.tsx
Outdated
Show resolved
Hide resolved
cb-jake
reviewed
Jun 29, 2023
cb-jake
reviewed
Jun 29, 2023
cb-jake
previously approved these changes
Jun 29, 2023
cb-jake
approved these changes
Jun 29, 2023
bangtoven
added a commit
that referenced
this pull request
Feb 29, 2024
* rename options.useMobileWalletLink to avoid confusion as react hook * rename WalletSDKUI => WalletLinkRelayUI * add MobileRelayUI * implementing MobileRelayUI * rename * fix rename * createWalletLinkUrl * implement MobileRelayUI * open the app after publishWeb3RequestEvent * further simplify * override publishEvent * revert * using timeout * nits * RedirectDialog adding RedirectDialog * for testing. needs to be reverted * ughghghagh * Revert "for testing. needs to be reverted" This reverts commit ff0153d. * this.redirectDialog.present called on openCoinbaseWalletDeeplink * remove logging * address comment * linter … * darkmode * darkmode
bangtoven
added a commit
that referenced
this pull request
Aug 16, 2024
* rename options.useMobileWalletLink to avoid confusion as react hook * rename WalletSDKUI => WalletLinkRelayUI * add MobileRelayUI * implementing MobileRelayUI * rename * fix rename * createWalletLinkUrl * implement MobileRelayUI * open the app after publishWeb3RequestEvent * further simplify * override publishEvent * revert * using timeout * nits * RedirectDialog adding RedirectDialog * for testing. needs to be reverted * ughghghagh * Revert "for testing. needs to be reverted" This reverts commit ff0153d. * this.redirectDialog.present called on openCoinbaseWalletDeeplink * remove logging * address comment * linter … * darkmode * darkmode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How did you test your changes?