-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Configuration File Support #70
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Pull Request Test Coverage Report for Build 1768
💛 - Coveralls |
patrick-ogrady
changed the title
[WIP] Configuration Overhaul
[WIP] Add Configuration File Support
Jul 23, 2020
patrick-ogrady
force-pushed
the
patrick/configuration-file
branch
from
July 23, 2020 15:21
69451f7
to
12c7f50
Compare
patrick-ogrady
force-pushed
the
patrick/configuration-file
branch
from
July 23, 2020 17:09
1d196c5
to
6113a33
Compare
patrick-ogrady
force-pushed
the
patrick/configuration-file
branch
2 times, most recently
from
July 23, 2020 17:28
9f861a7
to
c1d9958
Compare
patrick-ogrady
force-pushed
the
patrick/configuration-file
branch
from
July 23, 2020 17:32
c1d9958
to
3a0d4ba
Compare
patrick-ogrady
changed the title
[WIP] Add Configuration File Support
Add Configuration File Support
Jul 23, 2020
juliankoh
approved these changes
Jul 23, 2020
yfl92
reviewed
Jul 23, 2020
yfl92
approved these changes
Jul 23, 2020
patrick-ogrady
force-pushed
the
patrick/configuration-file
branch
from
July 23, 2020 17:50
9fb8fd0
to
997c73c
Compare
juliankoh
approved these changes
Jul 23, 2020
This Pull Request was merged without enough reviews |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #47
Related PR: #68
Changes
--configuration-file
flag (any missing fields populated by defaults)check
->check:data
check:construction
(not implemented yet)configuration:create <filePath>
(creates a default configuration file at thefilePath
)configuration:validate <filePath>
(ensures the configuration file atfilePath
is correctly formulated)create:configuration
->utils:asserter-configuration