Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Configuration File Support #70

Merged
merged 17 commits into from
Jul 23, 2020
Merged

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Jul 23, 2020

Fixes: #47
Related PR: #68

Changes

  • Add --configuration-file flag (any missing fields populated by defaults)
  • Rearrange commands to:
    • check -> check:data
    • check:construction (not implemented yet)
    • configuration:create <filePath> (creates a default configuration file at the filePath)
    • configuration:validate <filePath> (ensures the configuration file at filePath is correctly formulated)
    • create:configuration -> utils:asserter-configuration

@coveralls
Copy link

coveralls commented Jul 23, 2020

Pull Request Test Coverage Report for Build 1768

  • 122 of 138 (88.41%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.4%) to 66.215%

Changes Missing Coverage Covered Lines Changed/Added Lines %
configuration/configuration.go 122 138 88.41%
Totals Coverage Status
Change from base Build 1655: 3.4%
Covered Lines: 684
Relevant Lines: 1033

💛 - Coveralls

@patrick-ogrady patrick-ogrady changed the title [WIP] Configuration Overhaul [WIP] Add Configuration File Support Jul 23, 2020
@patrick-ogrady patrick-ogrady force-pushed the patrick/configuration-file branch 2 times, most recently from 9f861a7 to c1d9958 Compare July 23, 2020 17:28
@patrick-ogrady patrick-ogrady changed the title [WIP] Add Configuration File Support Add Configuration File Support Jul 23, 2020
cmd/root.go Outdated Show resolved Hide resolved
@patrick-ogrady patrick-ogrady merged commit 00983dd into master Jul 23, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/configuration-file branch July 23, 2020 17:55
@heimdall-asguard
Copy link

This Pull Request was merged without enough reviews
Please go here to review and +1

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Allow passing a configuration file to the validator
5 participants