Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JobStorage #118

Merged
merged 39 commits into from
Sep 1, 2020
Merged

Add JobStorage #118

merged 39 commits into from
Sep 1, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Aug 24, 2020

Related Issue: coinbase/mesh-cli#112

This PR adds JobStorage and includes a collection of small nits required to make automated construction API testing work.

Changes

  • Fix tests from Make Coordinator Fully Transactional #117
  • refactor construction package into job, worker, and coordinator
  • update broadcast storage with new interface
    • make BroadcastStorageHandler transactional
    • allow for CounterStorage to be transactional
  • add job storage
    • expose # completed for a job type
  • add coordinator handler for stats (matching pkg/constructor)
  • remove wait from find account (can use address requirement to ensure always retry on same account during a funds request) -> just need to keep in own scenario after an address has been created
  • support random_amount
  • when transaction confirmed, parse balance changes and print
  • force create new address with probability (otherwise will never create more addresses after first 2)

@coveralls
Copy link

coveralls commented Aug 25, 2020

Pull Request Test Coverage Report for Build 5613

  • 175 of 209 (83.73%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 78.495%

Changes Missing Coverage Covered Lines Changed/Added Lines %
constructor/worker/worker.go 76 91 83.52%
constructor/coordinator/coordinator.go 99 118 83.9%
Files with Coverage Reduction New Missed Lines %
constructor/coordinator/coordinator.go 2 69.59%
Totals Coverage Status
Change from base Build 5549: 0.4%
Covered Lines: 3358
Relevant Lines: 4278

💛 - Coveralls

@patrick-ogrady patrick-ogrady changed the title [WIP] Add Job Storage Add JobStorage Aug 31, 2020
constructor/job/job.go Outdated Show resolved Hide resolved
constructor/worker/types.go Outdated Show resolved Hide resolved
Copy link
Contributor

@cindyxkuang cindyxkuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@heimdall-asguard
Copy link

Review Error for cindyxkuang @ 2020-09-01 00:04:02 UTC
User failed mfa authentication, see go/mfa-help

@coinbase coinbase deleted a comment from heimdall-asguard Sep 1, 2020
@heimdall-asguard
Copy link

Review Error for cindyxkuang @ 2020-09-01 00:09:19 UTC
User failed mfa authentication, see go/mfa-help

cindyxkuang
cindyxkuang previously approved these changes Sep 1, 2020
Copy link
Contributor

@cindyxkuang cindyxkuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@patrick-ogrady patrick-ogrady merged commit 2c16b7a into master Sep 1, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/add-job-storage branch September 1, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants