Integrate Construction API 2.0 #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
Pull Request Test Coverage Report for Build 4357
💛 - Coveralls |
patrick-ogrady
force-pushed
the
patrick/new-construction-api
branch
from
6d4ebbb
to
bb9a8d9
Compare
patrick-ogrady
changed the title
patrick-ogrady
force-pushed
the
patrick/new-construction-api
branch
from
734377a
to
723fb65
Compare
qiwu7
reviewed
Sep 1, 2020
| func (c *ConstructorHelper) AllAddresses(ctx context.Context) ([]string, error) { | ||
| return c.keyStorage.GetAllAddresses(ctx) | ||
| // BroadcastAll attempts to broadcast all ready transactions. | ||
| func (c *CoordinatorHelper) BroadcastAll( |
There was a problem hiding this comment.
How does this method handle partial failures, i.e. if one broadcast fails, does the subsequent one also fails or it will continue broadcasting?
There was a problem hiding this comment.
The caller defines a BroadcastLimit for the max number of times to attempt re-broadcast (https://github.com/coinbase/rosetta-cli/blob/04f379541ad59a15a9cbf0e8472b12cedbcc2fa7/configuration/configuration.go#L186-L188) and if broadcast failures should be ignored (https://github.com/coinbase/rosetta-cli/blob/04f379541ad59a15a9cbf0e8472b12cedbcc2fa7/configuration/configuration.go#L190-L192).
TL;DR however you want!
qiwu7
approved these changes
Sep 1, 2020
cindyxkuang
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #112
Blocking PR: coinbase/mesh-sdk-go#118
Changes
constructioninconfigurationrosetta-sdk-go/constructor