Updated IsIsMasterDoc function to work with drivers that send IsMaste… #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r documents with 'isMaster' set to a boolean value instead of a number
mdehoog
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This fixes the following issue: #30
Summary
The node.js driver, and potentially other drivers, make a handshake with the
isMasterdocument formatted a little bit differently than what the current code expects. Theismaster|isMastervalue is a boolean, instead of a number. This is causing the isMaster command to breach the proxy and reach the server, and when sent with client metadata, causes the server to respond with the error:Here are examples of different drivers and how their document in this function appear:
node.js
{"ismaster": true,"helloOk": true,"client": {"driver": {"name": "nodejs","version": "4.2.0"},"os": {"type": "Darwin","name": "darwin","architecture": "x64","version": "20.6.0"},"platform": "Node.js v14.15.4, LE (unified)\|Node.js v14.15.4, LE (unified)"},"compression": ["none"],"loadBalanced": false}MongoDB Shell
{"isMaster": {"$numberInt":"1"},"client": {"application": {"name": "MongoDB Shell"},"driver": {"name": "MongoDB Internal Client","version": "4.4.0"},"os": {"type": "Darwin","name": "Mac OS X","architecture": "x86_64","version": "20.6.0"}}}PyMongo
{"ismaster": {"$numberInt":"1"},"helloOk": true,"client": {"driver": {"name": "PyMongo","version": "4.0"},"os": {"type": "Darwin","name": "Darwin","architecture": "x86_64","version": "10.16"},"platform": "CPython 3.9.4.final.0"}}Changes
This change will make drivers that pass in boolean values for
isMasterto be successfully intercepted.