Updated IsIsMasterDoc function to work with drivers that send IsMaste… #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This fixes the following issue: #30
Summary
The node.js driver, and potentially other drivers, make a handshake with the
isMaster
document formatted a little bit differently than what the current code expects. Theismaster
|isMaster
value is a boolean, instead of a number. This is causing the isMaster command to breach the proxy and reach the server, and when sent with client metadata, causes the server to respond with the error:Here are examples of different drivers and how their document in this function appear:
node.js
MongoDB Shell
PyMongo
Changes
This change will make drivers that pass in boolean values for
isMaster
to be successfully intercepted.