-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: moved onSuccess and onError for Swap at top level #1123
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -13,7 +13,9 @@ export function Swap({ | |||
children, | |||
className, | |||
experimental = { useAggregator: true }, | |||
onError, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will make the experience between Swap and Transaction similar.
In the next couple PRs, than I need to make the breaking change of removing those from the Button component.
@@ -13,6 +13,7 @@ export type { | |||
Fee, | |||
GetSwapQuoteParams, | |||
GetSwapQuoteResponse, | |||
LifeCycleStatus, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exporting this, so we can start making the changes in the docs and Playground.
statements: 99.65, | ||
branches: 99.65, | ||
statements: 99.67, | ||
branches: 99.7, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So close to 100!!!!!!!
What changed? Why?
Notes to reviewers
How has it been tested?