feat: moved onSuccess and onError for Swap at top level #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Zizzamia
commented
Aug 21, 2024
| @@ -13,7 +13,9 @@ export function Swap({ | |||
| children, | |||
| className, | |||
| experimental = { useAggregator: true }, | |||
| onError, | |||
There was a problem hiding this comment.
This will make the experience between Swap and Transaction similar.
In the next couple PRs, than I need to make the breaking change of removing those from the Button component.
Zizzamia
commented
Aug 21, 2024
| @@ -13,6 +13,7 @@ export type { | |||
| Fee, | |||
| GetSwapQuoteParams, | |||
| GetSwapQuoteResponse, | |||
| LifeCycleStatus, | |||
There was a problem hiding this comment.
Exporting this, so we can start making the changes in the docs and Playground.
Zizzamia
commented
Aug 21, 2024
| statements: 99.65, | ||
| branches: 99.65, | ||
| statements: 99.67, | ||
| branches: 99.7, |
There was a problem hiding this comment.
So close to 100!!!!!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Notes to reviewers
How has it been tested?