-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix WalletDropdown hover bug #1156
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
className, | ||
)} | ||
onClick={handleDisconnect} | ||
> | ||
<div className="-translate-y-1/2 absolute top-1/2 left-4 flex h-[1.125rem] w-[1.125rem] items-center justify-center"> | ||
<div className="absolute left-4 flex h-[1.125rem] w-[1.125rem] items-center justify-center"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed these classes that were not needed with items-center
@@ -38,7 +38,7 @@ export function WalletDropdown({ children, className }: WalletDropdownReact) { | |||
<div | |||
className={cn( | |||
pressable.default, | |||
'absolute right-0 z-10 mt-1 flex w-max min-w-[250px] flex-col overflow-hidden rounded-xl pb-2', | |||
'absolute right-0 z-10 mt-1 flex w-max min-w-[250px] flex-col overflow-hidden rounded-xl', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove bottom padding for the dropdown
@@ -19,12 +19,12 @@ export function WalletDropdownDisconnect({ | |||
type="button" | |||
className={cn( | |||
pressable.default, | |||
'relative flex items-center px-4 py-3', | |||
'relative flex items-center px-4 pt-3 pb-4', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the extra bottom padding to the disconnect button. This matches the padding for the Identity component.
This is a fix to a component, so it requires a |
19814bd
to
aa5853a
Compare
What changed? Why?
Remove the bottom WalletDropdown padding and instead apply the padding directly on the WalletDropdownDisconnect component. This fixes the on:hover bug of highlighting the border background while also aligns the direct padding with the Identity component.
Notes to reviewers
How has it been tested?