chore: Fix WalletDropdown hover bug #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cpcramer
commented
Aug 23, 2024
| className, | ||
| )} | ||
| onClick={handleDisconnect} | ||
| > | ||
| <div className="-translate-y-1/2 absolute top-1/2 left-4 flex h-[1.125rem] w-[1.125rem] items-center justify-center"> | ||
| <div className="absolute left-4 flex h-[1.125rem] w-[1.125rem] items-center justify-center"> |
There was a problem hiding this comment.
Removed these classes that were not needed with items-center
cpcramer
commented
Aug 23, 2024
| @@ -38,7 +38,7 @@ export function WalletDropdown({ children, className }: WalletDropdownReact) { | |||
| <div | |||
| className={cn( | |||
| pressable.default, | |||
| 'absolute right-0 z-10 mt-1 flex w-max min-w-[250px] flex-col overflow-hidden rounded-xl pb-2', | |||
| 'absolute right-0 z-10 mt-1 flex w-max min-w-[250px] flex-col overflow-hidden rounded-xl', | |||
There was a problem hiding this comment.
remove bottom padding for the dropdown
cpcramer
commented
Aug 23, 2024
| @@ -19,12 +19,12 @@ export function WalletDropdownDisconnect({ | |||
| type="button" | |||
| className={cn( | |||
| pressable.default, | |||
| 'relative flex items-center px-4 py-3', | |||
| 'relative flex items-center px-4 pt-3 pb-4', | |||
There was a problem hiding this comment.
Add the extra bottom padding to the disconnect button. This matches the padding for the Identity component.
cpcramer
changed the title
cpcramer
changed the title
|
This is a fix to a component, so it requires a |
cpcramer
force-pushed
the
paul/fix-bottom-padding-hover
branch
from
19814bd
to
aa5853a
Compare
Zizzamia
approved these changes
Aug 23, 2024
This was referenced Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Remove the bottom WalletDropdown padding and instead apply the padding directly on the WalletDropdownDisconnect component. This fixes the on:hover bug of highlighting the border background while also aligns the direct padding with the Identity component.
Notes to reviewers
How has it been tested?