GradleOSV Scanner #563
Merged
GradleOSV Scanner #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maitrayshah-cb
commented
Mar 3, 2022
•
maitrayshah-cb
commented
- Adding support for Gradle CVE Scanning.
- Handling various version strings.
- Adding SARIF support.
joshuaostrom-cb
suggested changes
Mar 15, 2022
|
Review Error for joshua-ostrom @ 2022-03-15 14:28:56 UTC |
ghbren
reviewed
Mar 18, 2022
ghbren
approved these changes
Mar 18, 2022
| return report_success if results.empty? | ||
|
|
||
| report_failure | ||
| log(JSON.pretty_generate(results)) |
There was a problem hiding this comment.
Did you intended to retain this loggin?
There was a problem hiding this comment.
Yes that's the one printing to console with the results
There was a problem hiding this comment.
We should really wrap these, but that can be a salus-wide change for another day
| scanner = Salus::Scanners::OSV::GradleOSV.new(repository: repo, config: {}) | ||
| stub_req_with_valid_response | ||
| scanner.run | ||
| report = Salus::Report.new(project_name: "Neon Genesis") |
joshuaostrom-cb
approved these changes
Mar 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.