Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Monitoring for Spawned Messages #18

Merged
merged 2 commits into from
Jul 29, 2024
Merged

feat: Add Monitoring for Spawned Messages #18

merged 2 commits into from
Jul 29, 2024

Conversation

yolo-vikram
Copy link
Collaborator

@yolo-vikram yolo-vikram commented Jul 18, 2024 •
edited
Loading

In this PR added -

  • monitoring for spawned messages.
  • Graceful shutdowns.
  • Update amqp version.

reshmalalwani3108
reshmalalwani3108 reviewed Jul 18, 2024
View reviewed changes
Copy link

@reshmalalwani3108 reshmalalwani3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me

lib/coney/connection_server.ex Outdated Show resolved Hide resolved
lib/coney/consumer_server.ex Outdated Show resolved Hide resolved
@yolo-vikram yolo-vikram merged commit 4eb4513 into main Jul 29, 2024
@yolo-vikram yolo-vikram deleted the monitor-spawned-task branch July 29, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesSoots JohannesSoots JohannesSoots left review comments

@reshmalalwani3108 reshmalalwani3108 reshmalalwani3108 left review comments

@ignaciogoldchluk-yolo ignaciogoldchluk-yolo ignaciogoldchluk-yolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yolo-vikram @JohannesSoots @reshmalalwani3108 @ignaciogoldchluk-yolo