fix: fix the Sidebar/Left Menu styling and align with React [MDS-107] #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/moon/autolayouts/top_to_down.ex
Outdated
| @@ -9,7 +9,7 @@ defmodule Moon.Autolayouts.TopToDown do | |||
|
|
|||
| def render(assigns) do | |||
| ~F""" | |||
| <div class={"flex flex-col gap-#{@gap} #{@gap} #{@class}"}> | |||
| <div class={"flex flex-col #{@gap} #{@gap} #{@class}"}> | |||
| prop height, :number, default: 24 | ||
|
|
||
| def render(assigns) do | ||
| ~F""" |
There was a problem hiding this comment.
Please put this to separate SVG file - otherwise caching etc does not work.
Because LiveViews are server side rendered, each time something changes, this means a lot more network traffic.
mxrguspxrtwork
requested changes
Jun 15, 2022
lib/moon/autolayouts/top_to_down.ex
Outdated
| @@ -9,7 +9,7 @@ defmodule Moon.Autolayouts.TopToDown do | |||
|
|
|||
| def render(assigns) do | |||
| ~F""" | |||
| <div class={"flex flex-col gap-#{@gap} #{@gap} #{@class}"}> | |||
| <div class={"flex flex-col #{@gap} #{@class}"}> | |||
There was a problem hiding this comment.
{"flex flex-col", @gap, @class}
lib/moon/components/chip.ex
Outdated
|
|
||
| defp active_btn_class(false, _, inactive_class), | ||
| do: "text-bulma-100 bg-gohan-100 #{inactive_class}" | ||
|
|
||
| defp set_bg_color(active, variant) do |
There was a problem hiding this comment.
- It is getter not setter, so function name should be get.
- let's please use standard surface class namings:
So bad style "some class list #{some_function(a, b)}"
Good style class={"class list", get_class(a, b), "more classes": c && d}
mxrguspxrtwork
requested changes
Jun 15, 2022
mxrguspxrtwork
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.