This repository has been archived by the owner on Jun 22, 2020. It is now read-only.
Add Binance ticker, and order book #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @weh Thank you for another PR. There has been some confusion and multiple different ways of outputting the orderbook, as such an abstraction is needed to keep things standardized. Referring to #175, you may want to update the OrderBook API to use those classes instead of the old style of array of array. Let me know what you think and if you need any help on that. |
|
Looks good to me. Thanks @weh 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Binance.com Ticker and Orderbook
Implement Binance Ticker, Orderbook, and Trades #144
Implement Binance Ticker, Orderbook, and Trades #79
volumeattributes is correctbaseandtargetis correct