This repository has been archived by the owner on Jun 22, 2020. It is now read-only.
Add Order class to abstract formatting into [price, amount, timestamp] #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0minicw0ng
reviewed
Oct 20, 2017
lib/cryptoexchange/models/order.rb
Outdated
| @timestamp = args[:timestamp] || nil | ||
| end | ||
|
|
||
| def format_as_list |
There was a problem hiding this comment.
@tmlee Actually, why do we need to do this? Can't we just return an array of Cryptoexchange::Models::Order ?
There was a problem hiding this comment.
@dominicwong617 That is possible. We just need to decide what end result we want to provide. Though i think returning as Order would give the user best flexibility how they want to store the results.
There was a problem hiding this comment.
@dominicwong617 now giving the user the choice to call this if they want to
There was a problem hiding this comment.
@tmlee let's just return an array of object as asks and bids, this choice doesn't add much benefits
tmlee
force-pushed
the
feature/order_abstraction
branch
from
0d54134
to
313cee6
Compare
2 tasks
tmlee
force-pushed
the
feature/order_abstraction
branch
from
313cee6
to
0e5e94f
Compare
tmlee
force-pushed
the
feature/order_abstraction
branch
from
0e5e94f
to
2b7ba13
Compare
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing OrderBook, there is no structure for individual Order.
Here is an abstraction of a Class, when assigned with price, amount, and timestamp will spit out the format we expect for all exchanges