Add yRange option
#21
Conversation
|
If you publish to a canary or something I can test it now in my app to confirm it's correct |
|
The one thing I'm missing is how to pass the min/max Y values to the context. I'd like to pass these as non-optional, so that you can consume them anywhere. @jxom how do you think I should do that? Should I add a |
|
@nandorojo – yeah, my knee jerk reaction was initially to have |
|
Do you think, in the context provider, I should actually do the logic for the user and set the real min and max, or just forward the prop down? I'm thinking I pass real values here, maybe under a different name ( |
…ext (non-optional, real values)
|
Just pushed new updates. I addressed your feedback, moved You should be able to consume |
|
@jxom thanks for reviewing! I missed the latest comment, but I pushed changes to resolve all outstanding requests. |
|
Legendary work. |
| }): string { | ||
| const timestamps = data.map(({}, i) => i); | ||
| const values = data.map(({ value }) => value); | ||
| const timestamps = data.map(({ timestamp }) => timestamp); |
There was a problem hiding this comment.
@jxom I just realized this was a mistake, it should be using the index rather than the actual time stamp.
There was a problem hiding this comment.
I opened a PR to fix this, small one-liner:
Resolve regression mentioned in coinjar#21 (comment)
* Update utils.ts Resolve regression mentioned in #21 (comment) * Update utils.ts
* feat & example: y range * docs: yRange * make requested changes, move yRange to provider; pass yDomain to context (non-optional, real values) * docs * resolve #21 * remove type * patch fix * fix example on web with reanimated patch from software-mansion/react-native-reanimated@09fb12f * close #24
* feat & example: y range * docs: yRange * make requested changes, move yRange to provider; pass yDomain to context (non-optional, real values) * docs * resolve #21 * remove type * patch fix * fix example on web with reanimated patch from software-mansion/react-native-reanimated@09fb12f * close #24 * feat: horizontal line with Y value * Update HorizontalLine.tsx Co-authored-by: Jake Moxey <jakemoxey@gmail.com>
RPReplay_Final1635380567.MP4
Closes #20