Fix issue with compress in uniprot search. #249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was trying to download compressed fasta from UniProt using bioservices
search
. But this function did not return compressed result, instead it returns an uncompressed fasta string.An example:
Returns:
It is caused by wrong parameter and value in the search function. This Pull request should fix this issue.
Do you think that the variable
compress
of search function should be renamed to matchcompressed
?I think not as it breaks compatibility with script using this function but as the other parameters seem to be matching the ones of Uniprot, I prefer asking this.