Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-taper future deprecation warning #49

Closed
xaratustrah opened this issue Sep 28, 2018 · 1 comment
Closed

multi-taper future deprecation warning #49

xaratustrah opened this issue Sep 28, 2018 · 1 comment

Comments

@xaratustrah
Copy link

xaratustrah commented Sep 28, 2018

There seems to be an issue regarding complex valued type conversion in mtm.py:

/Users/XXX/Library/anaconda3/lib/python3.6/site-packages/spectrum/mtm.py:529: FutureWarning: Conversion of the second argument of issubdtype from `complex` to `np.complexfloating` is deprecated. In future, it will be treated as `np.complex128 == np.dtype(complex).type`.
  complex_result = (np.issubdtype(in1.dtype, np.complex) or
/Users/XXX/Library/anaconda3/lib/python3.6/site-packages/spectrum/mtm.py:530: FutureWarning: Conversion of the second argument of issubdtype from `complex` to `np.complexfloating` is deprecated. In future, it will be treated as `np.complex128 == np.dtype(complex).type`.
  np.issubdtype(in2.dtype, np.complex))

I am using anaconda python 3.6.5 on macos.

@anielsen001
Copy link
Contributor

I made a pull request which will solve this issue. The _fftconvolve function is similar to the scipy.signal.fftconvolve function and the same change used there will work here.

cokelaer added a commit that referenced this issue Dec 10, 2018
fix for #49 complex valued type error.
Thanks for the pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants