Fix State Field Case Sensitivity for Ambassador Sign-Up

[ajones620]

Summary

As an Ambassador going through the sign-up workflow, I do not want to be blocked by entering my state in lowercase format so that I do not experience any friction in the sign-up process.

Requirements

• When I am signing up to be an Ambassador, if I enter either or both characters for my state in lowercase format, I should not see an error
• Currently the error message for using any lowercase characters is "Sorry, but state employment laws don't allow us to pay Voting Ambassadors in your state."

Current page/error message for reference:

[joshmaker]

I wonder if this change to HelloVoter would fix this issue:

diff --git a/server/app/services/ambassadors.js b/server/app/services/ambassadors.js
index 36b63662..f77aec95 100644
--- a/server/app/services/ambassadors.js
+++ b/server/app/services/ambassadors.js
@@ -59,8 +59,8 @@ async function signup(json) {
     throw new ValidationError("Our system doesn’t recognize that phone number. Please try again.");
   }

-  let allowed_states = ov_config.allowed_states.split(',');
-  if (allowed_states.indexOf(json.address.state) === -1) {
+  let allowed_states = ov_config.allowed_states.toUpperCase().split(',');
+  if (allowed_states.indexOf(json.address.state.toUpperCase()) === -1) {
     throw new ValidationError("Sorry, but state employment laws don't allow us to pay Voting Ambassadors in your state.")
   }

[joshmaker]

I think this ticket should be resolved now that colab-coop/HelloVoter#48 has been merged. Basically, I convert everything to uppercase on the backend that way the API can receive lower, upper, or mixed case state abbreviations and it won't matter.

[shauminn-colab]

That's so awesome @joshmaker - thank you! ill test it out on stage2 👍