Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit setuptools to version 44 #127

Merged
merged 2 commits into from
Jan 17, 2020
Merged

Limit setuptools to version 44 #127

merged 2 commits into from
Jan 17, 2020

Conversation

piraka9011
Copy link
Collaborator

From this issue it looks like setuptools after version 45 breaks python 2 builds.

Change the pip install to target setup tools version 44 only.

Signed-off-by: Anas Abou Allaban allabana@amazon.com

Limit setuptools to version 44
729cc66 
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
Fix flake8 and unittests
aa920ba 
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
zmichaels11
zmichaels11 approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@zmichaels11 zmichaels11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to extract the setuptools version from the code?

@piraka9011
Copy link
Collaborator Author

Would it be possible to extract the setuptools version from the code?

The unittests are checking that base_pip_installer.py is installing setuptools and that occurs only once in the install method. I'm not familiar with the code but there doesn't seem to be a programattic way to set the version in that method.

@thomas-moulard thomas-moulard merged commit a85d262 into colcon:master Jan 17, 2020
@piraka9011 piraka9011 mentioned this pull request Jan 29, 2020
Merged
@AAlon AAlon mentioned this pull request Mar 2, 2020
Closed
chutasano pushed a commit to chutasano/colcon-bundle that referenced this pull request May 28, 2020
@piraka9011 @chutasano
Limit setuptools to version 44 (colcon#127)
ffbe305 
* Limit setuptools to version 44

Signed-off-by: Anas Abou Allaban <allabana@amazon.com>

* Fix flake8 and unittests

Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-moulard thomas-moulard thomas-moulard approved these changes

@zmichaels11 zmichaels11 zmichaels11 approved these changes

@prajakta-gokhale prajakta-gokhale Awaiting requested review from prajakta-gokhale

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@piraka9011 @thomas-moulard @zmichaels11