-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use rc 0 when CTest has failing tests #3
Conversation
For future reference: there is no documentation about ctest return codes anywhere. This is ticketed at https://gitlab.kitware.com/cmake/cmake/issues/16151 |
I remember (couldnt find the discussion so far) user requests in the past to have the option of making builds fail on test failure. Can this override of the return code be made optional so that this can be toggled when invoking colcon test? |
I guess you are remember this discussion: ros-infrastructure/ros_buildfarm#367 (comment) At the time we settled on using the |
Thanks for the pointer, yeah I think that;s the discussion I was thinking of. In this case "colcon test" isn't able to perform the |
Correct,
Sure, such an option can be added as a new feature. I would keep that separate from this patch though. This patch addresses the problem which currently fails our CI builds and is therefore blocking the deployment of |
Feature addition ticketed at colcon/colcon-core#21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
While I couldn't find any documentation about it
CTest
returns8
when tests are failing. Since tests failures should not be considered an "error" in terms of invoking thetest
verb that case is handled differently. This unifies the return value semantic across other types.Before the failing bridge test made the build fail: https://ci.ros2.org/view/colcon/job/colcon_ci_packaging_linux-aarch64/5/
After the failing bridge test make the build only unstable: https://ci.ros2.org/view/colcon/job/colcon_ci_packaging_linux-aarch64/7/