Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_get_chained_prefix_path when AMENT_PREFIX_PATH is set #529

Closed
cottsay opened this issue Nov 1, 2022 · 0 comments · Fixed by #531
Closed

test_get_chained_prefix_path when AMENT_PREFIX_PATH is set #529

cottsay opened this issue Nov 1, 2022 · 0 comments · Fixed by #531

Comments

@cottsay
Copy link
Member

cottsay commented Nov 1, 2022

If AMENT_PREFIX_PATH is set when colcon-core tests are invoked and the necessary colcon extensions are also available, the test will fail because of the unexpected additional paths.

I think it would be prudent to either:
a) Make the test assert a change in paths, rather than an explicit list of paths
b) Explicitly set the list of available prefix path extensions to avoid the unexpected ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant