Fix prefix_path tests when AMENT_PREFIX_PATH is set #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These assertions fail when the AmentPrefixPath extension is loaded and the AMENT_PREFIX_PATH variable is populated. The assertions can be moved into the context manager which is already forcing the unexpected prefix path extensions to be ignored.
Codecov ReportBase: 81.66% // Head: 81.40% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #531 +/- ##
==========================================
- Coverage 81.66% 81.40% -0.26%
==========================================
Files 60 58 -2
Lines 3566 3362 -204
Branches 685 654 -31
==========================================
- Hits 2912 2737 -175
+ Misses 602 579 -23
+ Partials 52 46 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nuclearsandwich
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These assertions fail when the AmentPrefixPath extension is loaded and the AMENT_PREFIX_PATH variable is populated. The assertions can be moved into the context manager which is already forcing the unexpected prefix path extensions to be ignored.
Fixes #529