Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create unique log directory, avoiding race #130

Merged
merged 1 commit into from
Nov 6, 2018
Merged

Conversation

dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas commented Nov 3, 2018

Maybe addressing Fixes #129.

The patch ensures that the log directory doesn't exist yet. If it does a serial number is appended until it doesn't.

Without the patch two invocations started in the same second were writing to the same log directory.

@dirk-thomas dirk-thomas added enhancement New feature or request review Waiting for review (Kanban column) labels Nov 3, 2018
@dirk-thomas dirk-thomas self-assigned this Nov 3, 2018
@codecov-io
Copy link

Codecov Report

Merging #130 into master will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   78.37%   78.57%   +0.19%     
==========================================
  Files          51       51              
  Lines        2867     2884      +17     
  Branches      484      482       -2     
==========================================
+ Hits         2247     2266      +19     
+ Misses        594      592       -2     
  Partials       26       26
Impacted Files Coverage Δ
colcon_core/location.py 100% <100%> (+2.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7bc897...34f33d8. Read the comment docs.

@dirk-thomas
Copy link
Member Author

Confirmed that it fixes #129: #129 (comment)

@dirk-thomas dirk-thomas merged commit 404d04a into master Nov 6, 2018
@dirk-thomas dirk-thomas deleted the unique_log_dir branch November 6, 2018 18:19
@dirk-thomas dirk-thomas removed the review Waiting for review (Kanban column) label Nov 6, 2018
@dirk-thomas dirk-thomas added this to the 0.3.13 milestone Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

3 participants