add notes for Windows

[dirk-thomas]

Addresses the problem described in colcon/colcon-notification#4.

[sloretz]

@dirk-thomas Success!

Mind if I add some commits to this branch? I'd like to add notes about

• installing some dependencies to get the first build to succeed
• adding COLCON_IGNORE the argcomplete package since it fails to build on windows
• using curl to download the repos file since wget isn't available

Here's what worked for me

python -m venv env
call env\Scripts\activate
type nul > env\COLCON_IGNORE
pip install -U EmPy setuptools PyYAML pywin32 coloredlogs

curl --output colcon.repos https://raw.githubusercontent.com/colcon/colcon.readthedocs.org/master/colcon.repos
mkdir src
vcs import src < colcon.repos
type nul > src\colcon-argcomplete\COLCON_IGNORE

python src\colcon-core\bin\colcon build --paths src/*

call "install\setup.bat"
python install\colcon-core\Scripts\colcon-script.py build

[dirk-thomas]

Mind if I add some commits to this branch?

• adding COLCON_IGNORE the argcomplete package since it fails to build on windows
• using curl to download the repos file since wget isn't available

Sounds good to me.

• installing some dependencies to get the first build to succeed

I would keep that change separate from this. Also I don't think that any of the ones you mentioned are necessary. They are all mention in the setup files and are being installed already. Anyway since there are many others I would keep it separate to not "block" this one from getting merged soon. See #11 for a stub.

[mikaelarguedas]

/tmp on Windows ?
Maybe we can make all folder creations relative this way it should work on all platforms

[sloretz]

The windows note no longer references /tmp in 571e3f3

[dirk-thomas]

Since the new "Fetch the sources" instructions for Windows work on all platforms I am fine with keeping them in a single section.

[sloretz]

@mikaelarguedas Common download instructions in f0ecc1c

[dirk-thomas]

👍 LGTM.

I also removed the usage of tmp for the venv (ba8507d) and changed the wording from "skip" to "ignore" since they have slightly different meaning in the context of package selection (e576298).

[mikaelarguedas]

lgtm

We could specify to use call on Windows for sourcing the setup files but I don't think its required to get this merged

[dirk-thomas]

We could specify to use call on Windows for sourcing the setup files but I don't think its required to get this merged

I added about the script is being named and called on Windows in a7c192b (I didn't use call for it) and removed it from the activation script in a3229f9 (assuming that it was not required, maybe @sloretz can confirm?).

[sloretz]

@dirk-thomas I just checked and can confirm it works both with and without call.

Edit: to clarify I mean activating the virtual environment works both with and without call.

[dirk-thomas]

I added another related note in 455b739.