Allow Single Table Inheritance (STI) With Discriminated Entities #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made one minor change to better help differentiate between polymorphic discriminations vs single table discriminations. Since polymorphic came first in Quick, if the users want to use STI, they will have to include the `singleTableInheritance=true' metadata in their base class. This also has a nice side effect of preserving the polymorphic guard in case someone forgets to include their join column. |
|
This pull request has been mentioned on Ortus Solutions Community. There might be relevant details there: https://community.ortussolutions.com/t/coldbox-scheduled-tasks-a-couple-of-suggestions/9330/4 |
|
This pull request has been mentioned on Ortus Solutions Community. There might be relevant details there: |
Create data for testing Create models for testing Updates to Quick for handling STI Require metadata for Single Table Inheritance This should improve performance a bit and also helps separate polymorphic discriminators vs single table discriminators. Removed debugging code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the functionality of discriminated entities and allows for child classes to get their data from the same table as the parent without the need for a join column. This pattern is known as Single Table Inheritance (STI) and is quite common when developing apps where you do not always have control over the database or it's level or normalization.
Additionally, I also gave Quick some additional flexibility with the discriminator column so users can now use dot notation to indicate if the discriminator value should come from a different table which might be accessible via a join.