Add logic to force 2FA PIN on GHome-enabled user new lock device defi…

…nition
coldfire84 · Jan 24, 2020 · 30ae1a6 · 30ae1a6
1 parent 10d895d
commit 30ae1a6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/routes/default.js b/src/routes/default.js
@@ -538,6 +538,13 @@ router.put('/devices', defaultLimiter,
 			var device = req.body;
 			// Set username on device to match req.user.username
 			device.username = user;
+
+			// Sanity check new device
+			if (req.user.activeServices.indexOf('Google') > -1 && device.displayCategories == 'SMARTLOCK' && (!device.attributes.require2FA || !device.attributes.pin || !device.attributes.type2FA)){
+				logger.log('warning' , "[Create Device] Google Home user tried to create new Smart Lock device without a PIN");
+				res.status(500).send('As a Google Home user you must set a PIN on your lock!');
+			}
+
 			// Create new device
 			var dev = new Devices(device);
 			// Save device

diff --git a/src/routes/ghome.js b/src/routes/ghome.js
@@ -110,6 +110,7 @@ router.post('/action', defaultLimiter,
 					}
 					// FanSpeed, map 1:1 with RangeController 1-10
 					if (device.capabilities.indexOf("RangeController") > -1 && (dev.type.indexOf('action.devices.types.FAN') > -1 || dev.type.indexOf('action.devices.types.THERMOSTAT') > -1 )){
+						//dev.supportsFanSpeedPercent = true;
 						dev.attributes.availableFanSpeeds = {
 							"availableFanSpeeds": {
 							"speeds": [{