Add return to sanity checks on submit

coldfire84 · Jan 24, 2020 · cbe564f · cbe564f
1 parent ab4787a
commit cbe564f
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/routes/default.js b/src/routes/default.js
@@ -542,7 +542,7 @@ router.put('/devices', defaultLimiter,
 			// Sanity check new device
 			if (req.user.activeServices.indexOf('Google') > -1 && device.displayCategories == 'SMARTLOCK' && (!device.attributes.require2FA || !device.attributes.pin || !device.attributes.type2FA)){
 				logger.log('warning' , "[Create Device] Google Home user tried to create new Smart Lock device without a PIN");
-				res.status(500).send('As a Google Home user you must set a PIN on your lock!');
+				return res.status(500).send('As a Google Home user you must set a PIN on your lock!');
 			}
 
 			// Create new device
@@ -695,6 +695,13 @@ router.post('/device/:dev_id', defaultLimiter,
 				data.reportState = device.reportState;
 				data.attributes = device.attributes;
 				data.state = device.state;
+
+				// Sanity check new device
+				if (req.user.activeServices.indexOf('Google') > -1 && device.displayCategories == 'SMARTLOCK' && (!device.attributes.require2FA || !device.attributes.pin || !device.attributes.type2FA)){
+					logger.log('warning' , "[Create Device] Google Home user tried to create new Smart Lock device without a PIN");
+					return res.status(500).send('As a Google Home user you must set a PIN on your lock!');
+				}
+
 				// Save updated device
 				await data.save();
 				// Return 201 status