-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: Support library("tidyverse")
notation
#4
Comments
If I have time to write tests etc this is how I'd change the library call (and obv the require would also need to be changed)
Example: https://regexr.com/3s9ua |
Thanks for bringing this up. I hope to have some time during the next week to implement this fix. Pull request always welcome if you want to take a stab before I get to it. |
omg Cole - no tests present 😱 I'm gonna start your test harness as I have some time right now. Any objections to testthat? |
Please do! I’ve never used it but always wanted to.
… On Jul 12, 2018, at 11:51 AM, Stephanie Locke ***@***.***> wrote:
omg Cole - no tests present 😱
I'm gonna start your test harness as I have some time right now. Any objections to testthat?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This is now working in #5, just waiting for travis to complete |
Adding a test harness and implementing #4
thank you for showing me the testing ways @stephlocke 😎 merged! |
Speech marks are not supported in the CRAN or git version (as of Issue generation point). Taking the example from
parse_packages
:This should result in
The text was updated successfully, but these errors were encountered: